Skip to content

feat(service-terminal): enhance terminal functionality with quick actions and doc redirection#2542

Open
TheoGrandin74 wants to merge 7 commits intonew-navigationfrom
feat/new-nav/service-shell-improvments
Open

feat(service-terminal): enhance terminal functionality with quick actions and doc redirection#2542
TheoGrandin74 wants to merge 7 commits intonew-navigationfrom
feat/new-nav/service-shell-improvments

Conversation

@TheoGrandin74
Copy link
Copy Markdown
Contributor

@TheoGrandin74 TheoGrandin74 commented Mar 25, 2026

Summary

  • Added "CLI documentation" link redirection
  • Added a "Banner" in the terminal to inform people on how to access the cli on their local machine, with buttons to copy the command
  • Added a true empty state when the CLI is not working (because there's no pod for example)
  • Added new size in input search to match button size
  • Updated the text of the "search a pods" search to be more specific/informative on what's it really doing

Before
image

After
image
image

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Copy Markdown
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Write comments that add new information that doesn’t exist in the code

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 25.43353% with 129 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@f6ee9e6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ib/service-terminal/terminal-shell-banner-addon.ts 4.80% 119 Missing ⚠️
...ture/src/lib/service-terminal/service-terminal.tsx 77.77% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2542   +/-   ##
=================================================
  Coverage                  ?   45.30%           
=================================================
  Files                     ?      613           
  Lines                     ?    14324           
  Branches                  ?     4192           
=================================================
  Hits                      ?     6489           
  Misses                    ?     6678           
  Partials                  ?     1157           
Flag Coverage Δ
unittests 45.30% <25.43%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TheoGrandin74 TheoGrandin74 marked this pull request as ready for review March 27, 2026 16:36
match(runningStatuses?.state)
.with('STOPPED', () => "We could not launch the CLI for this service because it's stopped.")
.with('ERROR', () => "We could not launch the CLI for this service because it's in error.")
.otherwise(() => "We could not launch the CLI for this service because it's not running."),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are all the potential values for the state:

export declare const ServiceStateDto: {
    readonly STARTING: "STARTING";
    readonly RUNNING: "RUNNING";
    readonly ERROR: "ERROR";
    readonly STOPPING: "STOPPING";
    readonly STOPPED: "STOPPED";
    readonly COMPLETED: "COMPLETED";
    readonly WARNING: "WARNING";
};

Do we really want to fall back to "We could not launch the CLI for this service because it's not running." in all cases except for Stopped and Error?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well my approach is maybe a bit too simplistic, but most of the time user can't launch the CLI because there are no pods in their service, which is when services are either stopped or in error most of the time. I could have something for "Completed" also, but for the other states I'm not sure the CLI will fail because of a lack of pods 🤔

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to something more broad than just "Because it's not running" to avoid some confusion in some cases, I think it can suffice for now!

…rvice states and add corresponding test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants