feat(service-terminal): enhance terminal functionality with quick actions and doc redirection#2542
feat(service-terminal): enhance terminal functionality with quick actions and doc redirection#2542TheoGrandin74 wants to merge 7 commits intonew-navigationfrom
Conversation
…s and UI improvements
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2542 +/- ##
=================================================
Coverage ? 45.30%
=================================================
Files ? 613
Lines ? 14324
Branches ? 4192
=================================================
Hits ? 6489
Misses ? 6678
Partials ? 1157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nd action handling in terminal UI
…mproved placeholders and mock data in tests
| match(runningStatuses?.state) | ||
| .with('STOPPED', () => "We could not launch the CLI for this service because it's stopped.") | ||
| .with('ERROR', () => "We could not launch the CLI for this service because it's in error.") | ||
| .otherwise(() => "We could not launch the CLI for this service because it's not running."), |
There was a problem hiding this comment.
Here are all the potential values for the state:
export declare const ServiceStateDto: {
readonly STARTING: "STARTING";
readonly RUNNING: "RUNNING";
readonly ERROR: "ERROR";
readonly STOPPING: "STOPPING";
readonly STOPPED: "STOPPED";
readonly COMPLETED: "COMPLETED";
readonly WARNING: "WARNING";
};
Do we really want to fall back to "We could not launch the CLI for this service because it's not running." in all cases except for Stopped and Error?
There was a problem hiding this comment.
Well my approach is maybe a bit too simplistic, but most of the time user can't launch the CLI because there are no pods in their service, which is when services are either stopped or in error most of the time. I could have something for "Completed" also, but for the other states I'm not sure the CLI will fail because of a lack of pods 🤔
There was a problem hiding this comment.
Changed it to something more broad than just "Because it's not running" to avoid some confusion in some cases, I think it can suffice for now!
…rvice states and add corresponding test case
Summary
Before

After


Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release