Skip to content

feat(new-nav): add Helm networking settings view#2554

Merged
rmnbrd merged 10 commits intonew-navigationfrom
feat/new-nav/network-settings
Apr 9, 2026
Merged

feat(new-nav): add Helm networking settings view#2554
rmnbrd merged 10 commits intonew-navigationfrom
feat/new-nav/network-settings

Conversation

@rmnbrd
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd commented Mar 30, 2026

Summary

PR adding the "Networking" settings section for Helm services.


Note

Medium Risk
Adds a new Helm networking settings flow that mutates Helm service ports and refactors modal confirmation behaviors to await async actions, which could affect common destructive-action UX if edge cases weren’t covered.

Overview
Adds a real Helm service Networking settings page in console-v5, replacing the placeholder route with HelmNetworkingSettings that lists exposed ports (sorted), opens add/edit port modals, and persists changes via useEditService with safer last-public-port deletion confirmations.

Refactors shared confirmation modals (ModalConfirmation, ModalMultiConfirmation) and the Helm port modal to support async actions: buttons now disable/show loading while callbacks are pending and modals won’t close until the async operation completes (plus small copy/wording + styling tweaks and updated tests/snapshots).

Reviewed by Cursor Bugbot for commit 311a850. Bugbot is set up for automated code reviews on this repo. Configure here.

@rmnbrd rmnbrd added the V5 label Mar 30, 2026
@rmnbrd rmnbrd self-assigned this Mar 30, 2026
@rmnbrd rmnbrd force-pushed the feat/new-nav/network-settings branch from 489d8c3 to 1006296 Compare April 8, 2026 10:48
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 65.21739% with 24 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@ce870b5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...m-networking-settings/helm-networking-settings.tsx 63.04% 10 Missing and 7 partials ⚠️
...al-multi-confirmation/modal-multi-confirmation.tsx 63.63% 4 Missing ⚠️
...s/modals/modal-confirmation/modal-confirmation.tsx 80.00% 2 Missing ⚠️
...eature/src/lib/service-actions/service-actions.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2554   +/-   ##
=================================================
  Coverage                  ?   44.84%           
=================================================
  Files                     ?     1061           
  Lines                     ?    21866           
  Branches                  ?     6414           
=================================================
  Hits                      ?     9805           
  Misses                    ?    10314           
  Partials                  ?     1747           
Flag Coverage Δ
unittests 44.84% <65.21%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd marked this pull request as ready for review April 8, 2026 11:41
@rmnbrd rmnbrd requested review from RemiBonnet and Copilot April 8, 2026 11:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated “Networking” settings section for Helm services in the console-v5 settings flow, using a new HelmNetworkingSettings UI built in the service-settings domain.

Changes:

  • Introduces HelmNetworkingSettings component under @qovery/domains/service-settings/feature and exports it.
  • Removes the old NetworkingSetting component (and its tests/snapshots) from @qovery/domains/service-helm/feature, while keeping the port modal available.
  • Implements the console-v5 Helm networking settings route to edit Helm ports via useEditService + buildEditServicePayload.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
libs/domains/service-settings/feature/src/lib/helm-networking-settings/helm-networking-settings.tsx New Helm networking settings UI (ports list + add/edit/remove modals + delete confirmations).
libs/domains/service-settings/feature/src/index.ts Exports the new Helm networking settings component.
libs/domains/service-helm/feature/src/lib/networking-setting/networking-setting.tsx Removes the previous Helm networking settings component from the service-helm domain.
libs/domains/service-helm/feature/src/lib/networking-setting/networking-setting.spec.tsx Removes unit tests for the deleted NetworkingSetting.
libs/domains/service-helm/feature/src/lib/networking-setting/snapshots/networking-setting.spec.tsx.snap Removes snapshots for the deleted NetworkingSetting tests.
libs/domains/service-helm/feature/src/lib/networking-port-setting-modal/networking-port-setting-modal.tsx Minor styling change for helper text in the port modal.
libs/domains/service-helm/feature/src/lib/networking-port-setting-modal/snapshots/networking-port-setting-modal.spec.tsx.snap Updates snapshots to reflect the modal styling change.
libs/domains/service-helm/feature/src/index.ts Stops exporting NetworkingSetting; exports NetworkingPortSettingModal.
apps/console-v5/src/routes/_authenticated/.../settings/networking.tsx Implements Helm networking settings route using HelmNetworkingSettings and auto-submitting port changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread libs/domains/service-helm/feature/src/index.ts
Comment thread libs/shared/ui/src/lib/components/button/button.tsx Outdated
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 311a850. Configure here.

@rmnbrd rmnbrd force-pushed the feat/new-nav/network-settings branch from 311a850 to c92088e Compare April 9, 2026 13:18
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 9, 2026

You have used all of your free Bugbot PR reviews.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@rmnbrd rmnbrd merged commit eb8c18a into new-navigation Apr 9, 2026
11 checks passed
@rmnbrd rmnbrd deleted the feat/new-nav/network-settings branch April 9, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants