feat(new-nav): add Helm networking settings view#2554
feat(new-nav): add Helm networking settings view#2554rmnbrd merged 10 commits intonew-navigationfrom
Conversation
489d8c3 to
1006296
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2554 +/- ##
=================================================
Coverage ? 44.84%
=================================================
Files ? 1061
Lines ? 21866
Branches ? 6414
=================================================
Hits ? 9805
Misses ? 10314
Partials ? 1747
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a dedicated “Networking” settings section for Helm services in the console-v5 settings flow, using a new HelmNetworkingSettings UI built in the service-settings domain.
Changes:
- Introduces
HelmNetworkingSettingscomponent under@qovery/domains/service-settings/featureand exports it. - Removes the old
NetworkingSettingcomponent (and its tests/snapshots) from@qovery/domains/service-helm/feature, while keeping the port modal available. - Implements the console-v5 Helm networking settings route to edit Helm ports via
useEditService+buildEditServicePayload.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/domains/service-settings/feature/src/lib/helm-networking-settings/helm-networking-settings.tsx | New Helm networking settings UI (ports list + add/edit/remove modals + delete confirmations). |
| libs/domains/service-settings/feature/src/index.ts | Exports the new Helm networking settings component. |
| libs/domains/service-helm/feature/src/lib/networking-setting/networking-setting.tsx | Removes the previous Helm networking settings component from the service-helm domain. |
| libs/domains/service-helm/feature/src/lib/networking-setting/networking-setting.spec.tsx | Removes unit tests for the deleted NetworkingSetting. |
| libs/domains/service-helm/feature/src/lib/networking-setting/snapshots/networking-setting.spec.tsx.snap | Removes snapshots for the deleted NetworkingSetting tests. |
| libs/domains/service-helm/feature/src/lib/networking-port-setting-modal/networking-port-setting-modal.tsx | Minor styling change for helper text in the port modal. |
| libs/domains/service-helm/feature/src/lib/networking-port-setting-modal/snapshots/networking-port-setting-modal.spec.tsx.snap | Updates snapshots to reflect the modal styling change. |
| libs/domains/service-helm/feature/src/index.ts | Stops exporting NetworkingSetting; exports NetworkingPortSettingModal. |
| apps/console-v5/src/routes/_authenticated/.../settings/networking.tsx | Implements Helm networking settings route using HelmNetworkingSettings and auto-submitting port changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 311a850. Configure here.
311a850 to
c92088e
Compare
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |

Summary
PR adding the "Networking" settings section for Helm services.
Note
Medium Risk
Adds a new Helm networking settings flow that mutates Helm service ports and refactors modal confirmation behaviors to await async actions, which could affect common destructive-action UX if edge cases weren’t covered.
Overview
Adds a real Helm service Networking settings page in
console-v5, replacing the placeholder route withHelmNetworkingSettingsthat lists exposed ports (sorted), opens add/edit port modals, and persists changes viauseEditServicewith safer last-public-port deletion confirmations.Refactors shared confirmation modals (
ModalConfirmation,ModalMultiConfirmation) and the Helm port modal to support async actions: buttons now disable/show loading while callbacks are pending and modals won’t close until the async operation completes (plus small copy/wording + styling tweaks and updated tests/snapshots).Reviewed by Cursor Bugbot for commit 311a850. Bugbot is set up for automated code reviews on this repo. Configure here.