Skip to content

feat(helm): add settings values override as file/arguments#2577

Merged
RemiBonnet merged 2 commits intonew-navigationfrom
feat/new-nav/helm-settings
Apr 8, 2026
Merged

feat(helm): add settings values override as file/arguments#2577
RemiBonnet merged 2 commits intonew-navigationfrom
feat/new-nav/helm-settings

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Apr 7, 2026

Summary

Add settings views values override as file/arguments

Screenshots / Recordings

Screenshot 2026-04-07 at 10 58 13 Screenshot 2026-04-07 at 10 58 35

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet marked this pull request as ready for review April 7, 2026 09:03
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 71.56863% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.96%. Comparing base (933c1b9) to head (d8e8b73).
⚠️ Report is 6 commits behind head on new-navigation.

Files with missing lines Patch % Lines
...le-settings/helm-values-override-file-settings.tsx 73.21% 6 Missing and 9 partials ⚠️
...ttings/helm-values-override-arguments-settings.tsx 72.72% 4 Missing and 2 partials ⚠️
...de-files-setting/values-override-files-setting.tsx 54.54% 2 Missing and 3 partials ⚠️
...ents-setting/values-override-arguments-setting.tsx 83.33% 1 Missing and 1 partial ⚠️
...ride-yaml-setting/values-override-yaml-setting.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2577      +/-   ##
==================================================
+ Coverage           45.18%   51.96%   +6.78%     
==================================================
  Files                1112       52    -1060     
  Lines               22556     1422   -21134     
  Branches             6587      471    -6116     
==================================================
- Hits                10192      739    -9453     
+ Misses              10524      497   -10027     
+ Partials             1840      186    -1654     
Flag Coverage Δ
unittests 51.96% <71.56%> (+6.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@RemiBonnet RemiBonnet merged commit ce870b5 into new-navigation Apr 8, 2026
11 checks passed
@RemiBonnet RemiBonnet deleted the feat/new-nav/helm-settings branch April 8, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants