Skip to content

fix(ui): project breadcrumb sort and loading btn issue login page#2583

Merged
rmnbrd merged 3 commits intonew-navigationfrom
fix/new-nav/breadcrumb-project
Apr 9, 2026
Merged

fix(ui): project breadcrumb sort and loading btn issue login page#2583
rmnbrd merged 3 commits intonew-navigationfrom
fix/new-nav/breadcrumb-project

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Apr 8, 2026

Summary

  • Add favorite project in top on the breadcrumb
  • Hide icon when loading state for the login page
  • Improve responsive for header

Screenshots / Recordings

Before After
Screenshot 2026-04-09 at 09 10 15 Screenshot 2026-04-09 at 09 11 24

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet marked this pull request as ready for review April 8, 2026 15:28
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.31%. Comparing base (751939f) to head (8706681).
⚠️ Report is 5 commits behind head on new-navigation.

Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2583      +/-   ##
==================================================
- Coverage           45.85%   45.31%   -0.54%     
==================================================
  Files                1125      719     -406     
  Lines               22841    17017    -5824     
  Branches             6686     5019    -1667     
==================================================
- Hits                10474     7712    -2762     
+ Misses              10458     7925    -2533     
+ Partials             1909     1380     -529     
Flag Coverage Δ
unittests 45.31% <100.00%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet added the V5 label Apr 9, 2026
@rmnbrd rmnbrd merged commit ed785f4 into new-navigation Apr 9, 2026
11 of 12 checks passed
@rmnbrd rmnbrd deleted the fix/new-nav/breadcrumb-project branch April 9, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants