Skip to content

fix(accept-invitation): enhance UI and fix redirect issues#2584

Merged
RemiBonnet merged 6 commits intonew-navigationfrom
feat/new-nav/invit-members
Apr 9, 2026
Merged

fix(accept-invitation): enhance UI and fix redirect issues#2584
RemiBonnet merged 6 commits intonew-navigationfrom
feat/new-nav/invit-members

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Apr 9, 2026

Summary

Fix redirect issues with invitation members flow + improve UI

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet marked this pull request as ready for review April 9, 2026 10:13
@RemiBonnet RemiBonnet added the V5 label Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.14%. Comparing base (ed785f4) to head (f1a1316).
⚠️ Report is 1 commits behind head on new-navigation.

Files with missing lines Patch % Lines
.../lib/hooks/use-invite-member/use-invite-member.tsx 89.18% 4 Missing ⚠️
...re/src/lib/accept-invitation/accept-invitation.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2584      +/-   ##
==================================================
+ Coverage           45.28%   54.14%   +8.85%     
==================================================
  Files                1119       12    -1107     
  Lines               22820      314   -22506     
  Branches             6666       75    -6591     
==================================================
- Hits                10333      170   -10163     
+ Misses              10623      124   -10499     
+ Partials             1864       20    -1844     
Flag Coverage Δ
unittests 54.14% <87.17%> (+8.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@RemiBonnet RemiBonnet force-pushed the feat/new-nav/invit-members branch from 69917ab to 355d81e Compare April 9, 2026 11:42
@RemiBonnet RemiBonnet merged commit cf769de into new-navigation Apr 9, 2026
11 checks passed
@RemiBonnet RemiBonnet deleted the feat/new-nav/invit-members branch April 9, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants