Skip to content

feat(variable-modal): implement variable value editor modal and associated tests#2585

Merged
RemiBonnet merged 5 commits intonew-navigationfrom
feat/new-nav/variable-value-modal
Apr 9, 2026
Merged

feat(variable-modal): implement variable value editor modal and associated tests#2585
RemiBonnet merged 5 commits intonew-navigationfrom
feat/new-nav/variable-value-modal

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Apr 9, 2026

Summary

Add value editor for variable and variable as file creation flows

Screenshots / Recordings

https://www.loom.com/share/d36068304f5240f3a69cd61be205bb0a

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet added the V5 label Apr 9, 2026
@RemiBonnet RemiBonnet marked this pull request as ready for review April 9, 2026 13:50
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 51.42857% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.01%. Comparing base (cf769de) to head (797d999).
⚠️ Report is 2 commits behind head on new-navigation.

Files with missing lines Patch % Lines
...te-variable-modal/create-update-variable-modal.tsx 36.84% 7 Missing and 5 partials ⚠️
...value-editor-modal/variable-value-editor-modal.tsx 68.75% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2585      +/-   ##
==================================================
- Coverage           45.81%   45.01%   -0.80%     
==================================================
  Files                1129     1062      -67     
  Lines               22959    21898    -1061     
  Branches             6719     6425     -294     
==================================================
- Hits                10518     9858     -660     
+ Misses              10531    10272     -259     
+ Partials             1910     1768     -142     
Flag Coverage Δ
unittests 45.01% <51.42%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done 👍

@RemiBonnet RemiBonnet merged commit d19782f into new-navigation Apr 9, 2026
11 of 12 checks passed
@RemiBonnet RemiBonnet deleted the feat/new-nav/variable-value-modal branch April 9, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants