feat(announcement-banner): support multiple banners with carousel nav…#2587
Merged
RemiBonnet merged 7 commits intostagingfrom Apr 10, 2026
Merged
feat(announcement-banner): support multiple banners with carousel nav…#2587RemiBonnet merged 7 commits intostagingfrom
RemiBonnet merged 7 commits intostagingfrom
Conversation
…igation - Replace single banner with carousel supporting multiple banners from PostHog - Parse JSON string payloads returned by PostHog - Sort banners by priority (error > warning > info) - Persist dismissed banners by id (or message) in localStorage - Preserve backwards compatibility with legacy dismissed key Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #2587 +/- ##
===========================================
- Coverage 47.67% 47.31% -0.37%
===========================================
Files 1281 1233 -48
Lines 23858 23348 -510
Branches 7053 6956 -97
===========================================
- Hits 11374 11046 -328
+ Misses 10324 10213 -111
+ Partials 2160 2089 -71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Move navigation arrows next to dismiss button on the right - Add subtle vertical separator between arrows and dismiss - Unify button sizes and vertical alignment in a single absolute container Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…d improve button handling
…functionality - Replace currentIndex state with selectedBannerKey for improved banner selection logic - Update navigation handlers to set selectedBannerKey based on the current banner - Refactor button class names to utilize new BANNER_ICON_BUTTON_CLASSNAME and bannerButtonVariants for consistency - Simplify dismiss logic to handle single and multiple banners more effectively
…rove structure - Remove redundant BANNER_ICON_BUTTON_CLASSNAME export from banner component - Integrate button class names directly into the Button component for clarity - Maintain consistent styling across announcement banner and button components
RemiBonnet
approved these changes
Apr 10, 2026
Member
|
🎉 This PR is included in version 1.301.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for displaying multiple banners in the product instead of being limited to a single banner at a time.
Changes Included:
Summary
Issue: QOV-1822
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release