Skip to content

fix(ui): several improvement#2597

Merged
RemiBonnet merged 11 commits intonew-navigationfrom
fix/new-nav/ui-feedback
Apr 14, 2026
Merged

fix(ui): several improvement#2597
RemiBonnet merged 11 commits intonew-navigationfrom
fix/new-nav/ui-feedback

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Apr 14, 2026

Summary

  • Remove useless scrollbar on the User modal (slack)
  • Remove "Give feedback" item on the user dropdown (slack)
  • Rename "last deployment" to "last operation" in the service list (slack)
  • Fix variable toast glitch when we unselect values
  • Add cluster in the services header (slack)
  • Better manage header Services and Service with long name + the same thing for EnvironmentTable with long env name
  • Fix all plural statuses in the service list (slack)
  • Improve truncate cluster name in the env table (slack)

Screenshots / Recordings

Screenshot 2026-04-14 at 10 43 25 Screenshot 2026-04-14 at 10 43 43 Screenshot 2026-04-14 at 10 47 14 Screenshot 2026-04-14 at 10 56 13

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet changed the title Fix/new nav/UI feedback fix(ui): several improvement 2 Apr 14, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@c6154a3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rc/lib/user-settings-modal/user-settings-modal.tsx 62.50% 2 Missing and 1 partial ⚠️
...-table/environment-section/environment-section.tsx 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2597   +/-   ##
=================================================
  Coverage                  ?   45.69%           
=================================================
  Files                     ?     1122           
  Lines                     ?    23013           
  Branches                  ?     6719           
=================================================
  Hits                      ?    10515           
  Misses                    ?    10595           
  Partials                  ?     1903           
Flag Coverage Δ
unittests 45.69% <54.54%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet marked this pull request as ready for review April 14, 2026 08:56
@RemiBonnet RemiBonnet changed the title fix(ui): several improvement 2 fix(ui): several improvement Apr 14, 2026
@RemiBonnet RemiBonnet added the V5 label Apr 14, 2026
@TheoGrandin74
Copy link
Copy Markdown
Contributor

TheoGrandin74 commented Apr 14, 2026

@RemiBonnet

  • On the service list since we changed the copy to "Last operation" everywhere I think we need to update the empty state with "No operations yet" instead of "Never been deployed"
image
  • Minor, but seems like we struggle to retrieve sometimes the profile picture when coming from Google in the user settings. Maybe we need like the navbar a fallback when we have no image/it's not recognized with just the initials? Also could be great in the "Account email" input to have the google icon like we have for github
image

Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@RemiBonnet RemiBonnet merged commit c8c7313 into new-navigation Apr 14, 2026
12 checks passed
@RemiBonnet RemiBonnet deleted the fix/new-nav/ui-feedback branch April 14, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants