Skip to content

fix(page-settings): auto-select No Access when unchecking#2600

Merged
rmnbrd merged 3 commits intonew-navigationfrom
fix/QOV-1800/fix-rbac-uncheck-newnav
Apr 16, 2026
Merged

fix(page-settings): auto-select No Access when unchecking#2600
rmnbrd merged 3 commits intonew-navigationfrom
fix/QOV-1800/fix-rbac-uncheck-newnav

Conversation

@killiancolla
Copy link
Copy Markdown
Member

@killiancolla killiancolla commented Apr 14, 2026

Summary

Issue: QOV-1800

When you clicked on an already active permission to remove it, nothing happened. You had to click on "No Access" to disable it, which wasn't intuitive. Now, clicking on an already selected permission removes it automatically.

Screenshots / Recordings

Before After
https://github.com/user-attachments/assets/64173597-b9d9-41b7-bdcc-b2d4e92f8918 https://github.com/user-attachments/assets/96838bf5-3b3f-4c38-8dfe-1e0c16ceef63

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@c8c7313). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ib/settings-roles-edit/row-project/row-project.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2600   +/-   ##
=================================================
  Coverage                  ?   45.35%           
=================================================
  Files                     ?      613           
  Lines                     ?    14662           
  Branches                  ?     4301           
=================================================
  Hits                      ?     6650           
  Misses                    ?     6836           
  Partials                  ?     1176           
Flag Coverage Δ
unittests 45.35% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd merged commit 95c29bd into new-navigation Apr 16, 2026
11 checks passed
@rmnbrd rmnbrd deleted the fix/QOV-1800/fix-rbac-uncheck-newnav branch April 16, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants