fix(onboarding): add some fixes#2601
Merged
RemiBonnet merged 24 commits intonew-navigationfrom Apr 20, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2601 +/- ##
=================================================
Coverage ? 44.52%
=================================================
Files ? 1084
Lines ? 22418
Branches ? 6554
=================================================
Hits ? 9982
Misses ? 10669
Partials ? 1767
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…FreeTrialBanner and add new banner component
…k implementations
…ion and adjust navigation logic
…nization URL structure
Contributor
TheoGrandin74
left a comment
There was a problem hiding this comment.
Some feedbacks:
- A bit unrelated, but when I deleted my org (the only one), I'm redirected to a 404 page -> I should probably just be redirected to the login page
- I'm not redirected to my newly created organization on first creation. Sequence is [clicking on create org] -> [logout] -> [toast "org created] -> [redirected to project onboarding step]
- When user has dx_auth=true, he can't access the personalize step and therefore can't go back to previous step/disconnect when on the project step
- Here just make sure the max-height match the max-height we have on the project/env/services dropdown
…oks and adjusting navigation flow
…r improved navigation
…n in onboarding project component
…t adjustment based on footer action
… notifications and adjust organization creation logic
…analytics calls and adjusting toast notification placement
…ation creation event
…ion after organization creation
…d renderWithProviders for improved form context handling
…on existence check
…zed step handling
…rd restrictions in cluster creation flow
…rmProvider and enhancing error handling
…deployment to remove 'Desktop'
rmnbrd
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Warning: missing credit card field tokenization, I need to do it in a second PR
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release