Skip to content

fix(onboarding): add some fixes#2601

Merged
RemiBonnet merged 24 commits intonew-navigationfrom
fix/new-nav/onboarding
Apr 20, 2026
Merged

fix(onboarding): add some fixes#2601
RemiBonnet merged 24 commits intonew-navigationfrom
fix/new-nav/onboarding

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Apr 15, 2026

Summary

Warning: missing credit card field tokenization, I need to do it in a second PR

  • Add last element to be iso with current version
  • Add Pylon in the /organisation views
  • Add "create organisation" flow
  • Fix breadcrumb link (slack)

Screenshots / Recordings

Screenshot 2026-04-15 at 15 19 40

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet added the V5 label Apr 15, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 32.89474% with 102 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@c8c7313). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rd-modal-feature/add-credit-card-modal-feature.tsx 0.00% 51 Missing ⚠️
...on-restriction/use-cluster-creation-restriction.ts 0.00% 13 Missing ⚠️
...hooks/src/lib/use-support-chat/use-support-chat.ts 0.00% 10 Missing ⚠️
.../cluster-creation-flow/cluster-new/cluster-new.tsx 75.67% 7 Missing and 2 partials ⚠️
.../src/lib/onboarding-project/onboarding-project.tsx 57.14% 8 Missing and 1 partial ⚠️
...ding/feature/src/lib/step-project/step-project.tsx 42.85% 4 Missing ⚠️
...oks/use-edit-billing-info/use-edit-billing-info.ts 0.00% 2 Missing ⚠️
...lib/hooks/use-create-project/use-create-project.ts 0.00% 2 Missing ⚠️
...tings-billing-summary/settings-billing-summary.tsx 0.00% 0 Missing and 1 partial ⚠️
.../lib/settings-danger-zone/settings-danger-zone.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2601   +/-   ##
=================================================
  Coverage                  ?   44.52%           
=================================================
  Files                     ?     1084           
  Lines                     ?    22418           
  Branches                  ?     6554           
=================================================
  Hits                      ?     9982           
  Misses                    ?    10669           
  Partials                  ?     1767           
Flag Coverage Δ
unittests 44.52% <32.89%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet marked this pull request as ready for review April 15, 2026 13:19
Copy link
Copy Markdown
Contributor

@TheoGrandin74 TheoGrandin74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedbacks:

  • A bit unrelated, but when I deleted my org (the only one), I'm redirected to a 404 page -> I should probably just be redirected to the login page
Image - I'm not redirected to my newly created organization on first creation. Sequence is [clicking on create org] -> [logout] -> [toast "org created] -> [redirected to project onboarding step] - When user has dx_auth=true, he can't access the personalize step and therefore can't go back to previous step/disconnect when on the project step - Here just make sure the max-height match the max-height we have on the project/env/services dropdown Image

… notifications and adjust organization creation logic
…analytics calls and adjusting toast notification placement
…d renderWithProviders for improved form context handling
@RemiBonnet RemiBonnet merged commit 3b3167a into new-navigation Apr 20, 2026
11 checks passed
@RemiBonnet RemiBonnet deleted the fix/new-nav/onboarding branch April 20, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants