Skip to content

fix(ui): several improvement part 2#2609

Merged
RemiBonnet merged 9 commits intonew-navigationfrom
fix/new-nav/ui-feedback-2
Apr 21, 2026
Merged

fix(ui): several improvement part 2#2609
RemiBonnet merged 9 commits intonew-navigationfrom
fix/new-nav/ui-feedback-2

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Apr 20, 2026

Summary

  • Fix color Healthy nodes tooltip for cluster (slack)
  • Fix "deploy environment" button (slack)
  • Fix advanced settings save modification behavior (slack)
  • Add environment and service actions for deployment views (slack)
  • Add "last services opened" behavior in the service views for spotlight (slack)
  • Add "Service not found" page if service not available (slack)
  • Add link in the environment and service list for cmd+click (slack)
  • Fix audit logs links with services (slack)

Screenshots / Recordings

Screenshot 2026-04-21 at 14 35 44 Screenshot 2026-04-21 at 14 35 57 Screenshot 2026-04-21 at 15 33 26

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet added the V5 label Apr 20, 2026
@RemiBonnet RemiBonnet marked this pull request as ready for review April 20, 2026 15:11
@RemiBonnet RemiBonnet marked this pull request as draft April 20, 2026 15:11
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 84.44444% with 7 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@17d6507). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ced-settings/cluster-advanced-settings-feature.tsx 0.00% 2 Missing ⚠️
...nt-section/environment-last-deployment-section.tsx 33.33% 1 Missing and 1 partial ⚠️
...eature/src/lib/service-actions/service-actions.tsx 77.77% 0 Missing and 2 partials ⚠️
...vice-list/service-list-cells/service-name-cell.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2609   +/-   ##
=================================================
  Coverage                  ?   44.95%           
=================================================
  Files                     ?      714           
  Lines                     ?    17238           
  Branches                  ?     5103           
=================================================
  Hits                      ?     7749           
  Misses                    ?     8120           
  Partials                  ?     1369           
Flag Coverage Δ
unittests 44.95% <84.44%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ecent services tracking and project/environment data retrieval
… actions and improve service not found handling in OrganizationRoute
@RemiBonnet RemiBonnet marked this pull request as ready for review April 21, 2026 13:27
…e links and improve target link rendering for various event types
Copy link
Copy Markdown
Contributor

@TheoGrandin74 TheoGrandin74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image For this interaction with the cmd+click to open the page in a new tab like asked Fabien, could we maybe just put it in the whole row instead of just the name of the environment? Also we can remove the underline hover in that case

@RemiBonnet
Copy link
Copy Markdown
Member Author

Image For this interaction with the cmd+click to open the page in a new tab like asked Fabien, could we maybe just put it in the whole row instead of just the name of the environment? Also we can remove the underline hover in that case

@TheoGrandin74 I checked it, but putting the real link on the whole row is a bit messy semantically because the row has other content/actions inside it. So wrapping everything would not be great HTML/accessibility-wise

I’d keep the row click as-is, and just make the env/service name a real link, which is what we had in the current version too. That gives the cmd+click/open in new tab behavior without breaking the row structure

And yep I can remove the underline hover, no problem!

@RemiBonnet RemiBonnet merged commit 6a865a6 into new-navigation Apr 21, 2026
13 checks passed
@RemiBonnet RemiBonnet deleted the fix/new-nav/ui-feedback-2 branch April 21, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants