Skip to content

feat(new-nav): add Dockerfile settings section#2615

Merged
rmnbrd merged 6 commits intonew-navigationfrom
feat/new-nav/dockerfile-settings
Apr 22, 2026
Merged

feat(new-nav): add Dockerfile settings section#2615
rmnbrd merged 6 commits intonew-navigationfrom
feat/new-nav/dockerfile-settings

Conversation

@rmnbrd
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd commented Apr 21, 2026

Summary

PR adding the "Dockerfile" settings section

Screenshots / Recordings

Screenshot 2026-04-22 at 16 28 47

@rmnbrd rmnbrd self-assigned this Apr 21, 2026
@rmnbrd rmnbrd force-pushed the feat/new-nav/dockerfile-settings branch from 4087ab3 to 71078c7 Compare April 22, 2026 14:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@76e2ccc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ob-dockerfile-settings/job-dockerfile-settings.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2615   +/-   ##
=================================================
  Coverage                  ?   45.32%           
=================================================
  Files                     ?      632           
  Lines                     ?    15086           
  Branches                  ?     4417           
=================================================
  Hits                      ?     6838           
  Misses                    ?     7056           
  Partials                  ?     1192           
Flag Coverage Δ
unittests 45.32% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd marked this pull request as ready for review April 22, 2026 15:15
Copilot AI review requested due to automatic review settings April 22, 2026 15:15
@rmnbrd rmnbrd added the V5 label Apr 22, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a “Dockerfile” section to the new service settings navigation (for lifecycle jobs with a git source) by wiring a new settings page into the console route and exposing a new JobDockerfileSettings feature component.

Changes:

  • Introduces JobDockerfileSettings and routes /settings/dockerfile to it.
  • Tweaks Dockerfile raw editor UI controls (icon-only edit button styling + copy button hover color).
  • Removes the legacy snapshot test for the old application Dockerfile settings feature.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
libs/pages/application/src/lib/feature/page-settings-dockerfile-feature/page-settings-dockerfile-feature.spec.tsx Removes legacy snapshot test for the old application Dockerfile settings page.
libs/pages/application/src/lib/feature/page-settings-dockerfile-feature/snapshots/page-settings-dockerfile-feature.spec.tsx.snap Removes associated Jest snapshot.
libs/domains/services/feature/src/lib/dockerfile-settings/dockerfile-settings.tsx Makes the raw Dockerfile edit button icon-only and adjusts hover styling.
libs/domains/services/feature/src/lib/dockerfile-raw-modal/dockerfile-raw-modal.tsx Updates copy-to-clipboard hover text color token.
libs/domains/service-settings/feature/src/lib/job-dockerfile-settings/job-dockerfile-settings.tsx Adds the job Dockerfile settings implementation and submit logic.
libs/domains/service-settings/feature/src/index.ts Exports JobDockerfileSettings from the feature package.
apps/console-v5/src/routes/_authenticated/organization/$organizationId/project/$projectId/environment/$environmentId/service/$serviceId/settings/dockerfile.tsx Wires the new Dockerfile settings route to JobDockerfileSettings.
Comments suppressed due to low confidence (1)

libs/domains/service-settings/feature/src/lib/job-dockerfile-settings/job-dockerfile-settings.tsx:78

  • useForm is initialized before the service data is available (and the component returns null while loading). Because defaultValues are only applied on the first render, the form won’t be prefilled with the service’s current Dockerfile settings once useService resolves. Consider switching useService to suspense: true (as in JobConfiguration) so the component doesn’t render until service is loaded, or call dockerfileForm.reset(...) in an effect when service becomes available; this also avoids rendering a blank page during the initial load.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmnbrd !
The components dockerfile-raw-modal and dockerfile-settings should be in the domain service-jobs no?

Comment thread libs/domains/services/feature/src/lib/dockerfile-settings/dockerfile-settings.tsx Outdated
@RemiBonnet RemiBonnet self-requested a review April 22, 2026 15:39
@rmnbrd rmnbrd merged commit 7c75e9c into new-navigation Apr 22, 2026
11 checks passed
@rmnbrd rmnbrd deleted the feat/new-nav/dockerfile-settings branch April 22, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants