feat(new-nav): add Dockerfile settings section#2615
Conversation
4087ab3 to
71078c7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2615 +/- ##
=================================================
Coverage ? 45.32%
=================================================
Files ? 632
Lines ? 15086
Branches ? 4417
=================================================
Hits ? 6838
Misses ? 7056
Partials ? 1192
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a “Dockerfile” section to the new service settings navigation (for lifecycle jobs with a git source) by wiring a new settings page into the console route and exposing a new JobDockerfileSettings feature component.
Changes:
- Introduces
JobDockerfileSettingsand routes/settings/dockerfileto it. - Tweaks Dockerfile raw editor UI controls (icon-only edit button styling + copy button hover color).
- Removes the legacy snapshot test for the old application Dockerfile settings feature.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| libs/pages/application/src/lib/feature/page-settings-dockerfile-feature/page-settings-dockerfile-feature.spec.tsx | Removes legacy snapshot test for the old application Dockerfile settings page. |
| libs/pages/application/src/lib/feature/page-settings-dockerfile-feature/snapshots/page-settings-dockerfile-feature.spec.tsx.snap | Removes associated Jest snapshot. |
| libs/domains/services/feature/src/lib/dockerfile-settings/dockerfile-settings.tsx | Makes the raw Dockerfile edit button icon-only and adjusts hover styling. |
| libs/domains/services/feature/src/lib/dockerfile-raw-modal/dockerfile-raw-modal.tsx | Updates copy-to-clipboard hover text color token. |
| libs/domains/service-settings/feature/src/lib/job-dockerfile-settings/job-dockerfile-settings.tsx | Adds the job Dockerfile settings implementation and submit logic. |
| libs/domains/service-settings/feature/src/index.ts | Exports JobDockerfileSettings from the feature package. |
| apps/console-v5/src/routes/_authenticated/organization/$organizationId/project/$projectId/environment/$environmentId/service/$serviceId/settings/dockerfile.tsx | Wires the new Dockerfile settings route to JobDockerfileSettings. |
Comments suppressed due to low confidence (1)
libs/domains/service-settings/feature/src/lib/job-dockerfile-settings/job-dockerfile-settings.tsx:78
useFormis initialized before the service data is available (and the component returnsnullwhile loading). BecausedefaultValuesare only applied on the first render, the form won’t be prefilled with the service’s current Dockerfile settings onceuseServiceresolves. Consider switchinguseServicetosuspense: true(as inJobConfiguration) so the component doesn’t render untilserviceis loaded, or calldockerfileForm.reset(...)in an effect whenservicebecomes available; this also avoids rendering a blank page during the initial load.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RemiBonnet
left a comment
There was a problem hiding this comment.
Thanks @rmnbrd !
The components dockerfile-raw-modal and dockerfile-settings should be in the domain service-jobs no?
Summary
PR adding the "Dockerfile" settings section
Screenshots / Recordings