Skip to content

fix(new-nav): cluster mirroring registry data not loaded#2623

Merged
rmnbrd merged 2 commits intonew-navigationfrom
fix/new-nav/cluster-mirroring-registry-data-not-loaded
Apr 23, 2026
Merged

fix(new-nav): cluster mirroring registry data not loaded#2623
rmnbrd merged 2 commits intonew-navigationfrom
fix/new-nav/cluster-mirroring-registry-data-not-loaded

Conversation

@rmnbrd
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd commented Apr 23, 2026

Summary

Issue: The data of the cluster's "mirroring registry" settings section was not loading at all.
Slack thread for reference.

Screenshots / Recordings

Before After
image (21) Screenshot 2026-04-23 at 10 30 23

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (new-navigation@0e9ac1e). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2623   +/-   ##
=================================================
  Coverage                  ?   44.17%           
=================================================
  Files                     ?      726           
  Lines                     ?    17690           
  Branches                  ?     5250           
=================================================
  Hits                      ?     7815           
  Misses                    ?     8500           
  Partials                  ?     1375           
Flag Coverage Δ
unittests 44.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd added the V5 label Apr 23, 2026
@rmnbrd rmnbrd self-assigned this Apr 23, 2026
@rmnbrd rmnbrd marked this pull request as ready for review April 23, 2026 08:33
Copilot AI review requested due to automatic review settings April 23, 2026 08:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the cluster “Mirroring registry” settings page in Console v5 so the registry data renders correctly by switching the registry query to Suspense mode and adding a local loading fallback.

Changes:

  • Wrap the mirroring registry settings content in a <Suspense> boundary with a spinner fallback.
  • Enable suspense: true on useContainerRegistries to ensure the form initializes after data is available.
  • Minor UI tweak: increase loader spinner size in cluster network settings.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
libs/domains/clusters/feature/src/lib/cluster-network-settings/cluster-network-settings.tsx Slightly increases the loading spinner size.
apps/console-v5/src/routes/_authenticated/organization/$organizationId/cluster/$clusterId/settings/image-registry.tsx Adds a Suspense boundary + spinner fallback and enables React Query suspense for container registries to ensure data-backed form initialization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rmnbrd rmnbrd requested a review from RemiBonnet April 23, 2026 10:30
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I just added one comment

@rmnbrd rmnbrd merged commit 4e5a3d8 into new-navigation Apr 23, 2026
10 checks passed
@rmnbrd rmnbrd deleted the fix/new-nav/cluster-mirroring-registry-data-not-loaded branch April 23, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants