fix(new-nav): cluster mirroring registry data not loaded#2623
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2623 +/- ##
=================================================
Coverage ? 44.17%
=================================================
Files ? 726
Lines ? 17690
Branches ? 5250
=================================================
Hits ? 7815
Misses ? 8500
Partials ? 1375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Fixes the cluster “Mirroring registry” settings page in Console v5 so the registry data renders correctly by switching the registry query to Suspense mode and adding a local loading fallback.
Changes:
- Wrap the mirroring registry settings content in a
<Suspense>boundary with a spinner fallback. - Enable
suspense: trueonuseContainerRegistriesto ensure the form initializes after data is available. - Minor UI tweak: increase loader spinner size in cluster network settings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libs/domains/clusters/feature/src/lib/cluster-network-settings/cluster-network-settings.tsx | Slightly increases the loading spinner size. |
| apps/console-v5/src/routes/_authenticated/organization/$organizationId/cluster/$clusterId/settings/image-registry.tsx | Adds a Suspense boundary + spinner fallback and enables React Query suspense for container registries to ensure data-backed form initialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RemiBonnet
left a comment
There was a problem hiding this comment.
LGTM 👍 I just added one comment
Summary
Issue: The data of the cluster's "mirroring registry" settings section was not loading at all.
Slack thread for reference.
Screenshots / Recordings