Skip to content

fix(new-nav): remove deprecated checkRunningStatusClosed query and fix service table re-rendering issue#2625

Merged
rmnbrd merged 5 commits intonew-navigationfrom
fix/new-nav/websocket-issue
Apr 23, 2026
Merged

fix(new-nav): remove deprecated checkRunningStatusClosed query and fix service table re-rendering issue#2625
rmnbrd merged 5 commits intonew-navigationfrom
fix/new-nav/websocket-issue

Conversation

@rmnbrd
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd commented Apr 23, 2026

Summary

This PR:

  • removes the deprecated checkRunningStatusClosed query
  • fixes service table re-rendering issue
  • fixes failing unit tests from new-navigation branch

Screenshots / Recordings

📺 https://www.loom.com/share/759a0dc1ef3f4571872f25bc4ac48f87

@rmnbrd rmnbrd changed the title Remove deprecated checkRunningStatusClosed query fix(new-nav): remove deprecated checkRunningStatusClosed query and fix service table re-rendering issue Apr 23, 2026
@rmnbrd rmnbrd added the V5 label Apr 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 12.50000% with 21 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@0e9ac1e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...feature/src/lib/hooks/use-services/use-services.ts 0.00% 21 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2625   +/-   ##
=================================================
  Coverage                  ?   45.40%           
=================================================
  Files                     ?     1094           
  Lines                     ?    22968           
  Branches                  ?     6770           
=================================================
  Hits                      ?    10429           
  Misses                    ?    10663           
  Partials                  ?     1876           
Flag Coverage Δ
unittests 45.40% <12.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd marked this pull request as ready for review April 23, 2026 11:50
Copilot AI review requested due to automatic review settings April 23, 2026 11:50
@rmnbrd rmnbrd self-assigned this Apr 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated “checkRunningStatusClosed” React Query keys/hooks that were fed by WebSocket close events, and adjusts status WebSocket scoping + service table memoization to reduce unnecessary re-renders and fix failing tests.

Changes:

  • Removed deprecated checkRunningStatusClosed query keys and feature hooks (services + environments) and corresponding consumer logic.
  • Scoped status WebSocket listeners to reduce unnecessary connections during environment loading, and stabilized service table column definitions to prevent re-render churn.
  • Updated SelectCommitModal unit test to be timezone/relative-time stable and refreshed snapshots.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
libs/shared/util-web-sockets/src/lib/use-status-web-sockets/use-status-web-sockets.ts Removes the onClose “closed status” cache update for NotFound closes.
libs/pages/layout/src/lib/feature/layout/layout.tsx Memoizes/scopes clusters used for status WebSocket listeners to avoid opening many sockets during env loading.
libs/domains/services/feature/src/lib/service-list/service-list.tsx Moves createColumnHelper into the columns useMemo to stabilize columns and reduce table re-renders; adjusts selection click handling.
libs/domains/services/feature/src/lib/select-commit-modal/select-commit-modal.spec.tsx Mocks date utilities to make snapshots stable across timezones/runs; updates mocked commit timestamps.
libs/domains/services/feature/src/lib/select-commit-modal/snapshots/select-commit-modal.spec.tsx.snap Snapshot updates reflecting stabilized dates/text.
libs/domains/services/feature/src/lib/hooks/use-services/use-services.ts Minor refactor of memoized mapping for service status decoration.
libs/domains/services/feature/src/lib/hooks/use-check-running-status-closed/use-check-running-status-closed.ts Deletes deprecated hook.
libs/domains/services/data-access/src/lib/domains-services-data-access.ts Removes deprecated checkRunningStatusClosed query key.
libs/domains/environments/feature/src/lib/hooks/use-check-running-status-closed/use-check-running-status-closed.ts Deletes deprecated hook.
libs/domains/environments/feature/src/lib/environment-state-chip/environment-state-chip.tsx Removes “closed status” fallback logic from the running state chip.
libs/domains/environments/data-access/src/lib/domains-environments-data-access.ts Removes deprecated checkRunningStatusClosed query key.
tests/mocks.ts Tightens Auth0 mock typing (children + HOC component type).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread libs/domains/services/feature/src/lib/service-list/service-list.tsx
Comment thread libs/domains/services/feature/src/lib/service-list/service-list.tsx
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thank you!

@rmnbrd rmnbrd merged commit 864de06 into new-navigation Apr 23, 2026
16 checks passed
@rmnbrd rmnbrd deleted the fix/new-nav/websocket-issue branch April 23, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants