fix(new-nav): add missing buttons to env list#2626
Merged
rmnbrd merged 1 commit intonew-navigationfrom Apr 23, 2026
Merged
Conversation
7e69240 to
e747916
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures environments with zero services still show the expected actions in the environments list (instead of having an empty “Actions” cell), aligning the new navigation behavior with UI expectations.
Changes:
- Add a disabled “Manage Deployment” button (with tooltip) when an environment has no services / no deployment status.
- Always render the “Other actions” menu when the environment exists, defaulting state when deployment status is missing.
- Add a unit test covering the “no services” action rendering and tooltip behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libs/domains/environments/feature/src/lib/environments-table/environment-section/environment-section.tsx | Adds a disabled Manage Deployment action (with tooltip) and ensures Other actions still renders for empty environments. |
| libs/domains/environments/feature/src/lib/environments-table/environment-section/environment-section.spec.tsx | Adds test coverage for rendering both actions when service count is 0 and deployment status is missing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2626 +/- ##
=================================================
Coverage ? 43.88%
=================================================
Files ? 634
Lines ? 15250
Branches ? 4471
=================================================
Hits ? 6693
Misses ? 7411
Partials ? 1146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue: When an environment does not have any services yet, we should still have button in the environments list.
Slack thread for reference.
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release