Skip to content

fix(new-nav): add missing buttons to env list#2626

Merged
rmnbrd merged 1 commit intonew-navigationfrom
fix/new-nav/missing-buttons-env-list
Apr 23, 2026
Merged

fix(new-nav): add missing buttons to env list#2626
rmnbrd merged 1 commit intonew-navigationfrom
fix/new-nav/missing-buttons-env-list

Conversation

@rmnbrd
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd commented Apr 23, 2026

Summary

Issue: When an environment does not have any services yet, we should still have button in the environments list.

Slack thread for reference.

Screenshots / Recordings

Before After
Capture d’écran 2026-04-22 à 14 39 42 (2) Screenshot 2026-04-23 at 16 03 08

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@rmnbrd rmnbrd self-assigned this Apr 23, 2026
@rmnbrd rmnbrd added the V5 label Apr 23, 2026
@rmnbrd rmnbrd force-pushed the fix/new-nav/missing-buttons-env-list branch from 7e69240 to e747916 Compare April 23, 2026 14:07
@rmnbrd rmnbrd marked this pull request as ready for review April 23, 2026 14:07
Copilot AI review requested due to automatic review settings April 23, 2026 14:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures environments with zero services still show the expected actions in the environments list (instead of having an empty “Actions” cell), aligning the new navigation behavior with UI expectations.

Changes:

  • Add a disabled “Manage Deployment” button (with tooltip) when an environment has no services / no deployment status.
  • Always render the “Other actions” menu when the environment exists, defaulting state when deployment status is missing.
  • Add a unit test covering the “no services” action rendering and tooltip behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
libs/domains/environments/feature/src/lib/environments-table/environment-section/environment-section.tsx Adds a disabled Manage Deployment action (with tooltip) and ensures Other actions still renders for empty environments.
libs/domains/environments/feature/src/lib/environments-table/environment-section/environment-section.spec.tsx Adds test coverage for rendering both actions when service count is 0 and deployment status is missing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (new-navigation@d49126f). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2626   +/-   ##
=================================================
  Coverage                  ?   43.88%           
=================================================
  Files                     ?      634           
  Lines                     ?    15250           
  Branches                  ?     4471           
=================================================
  Hits                      ?     6693           
  Misses                    ?     7411           
  Partials                  ?     1146           
Flag Coverage Δ
unittests 43.88% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd requested a review from RemiBonnet April 23, 2026 14:19
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rmnbrd rmnbrd merged commit df5ecdf into new-navigation Apr 23, 2026
15 checks passed
@rmnbrd rmnbrd deleted the fix/new-nav/missing-buttons-env-list branch April 23, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants