feat(organization-overview): improve cluster summary#2627
Merged
RemiBonnet merged 5 commits intonew-navigationfrom Apr 24, 2026
Merged
feat(organization-overview): improve cluster summary#2627RemiBonnet merged 5 commits intonew-navigationfrom
RemiBonnet merged 5 commits intonew-navigationfrom
Conversation
RemiBonnet
force-pushed
the
feat/new-nav/orga-overview-clusters
branch
from
d21e883 to
c75189b
Compare
Contributor
|
Yop @RemiBonnet, some quick feedbacks I've spotted:
- Btw we have this same issue on the cluster page... Here I think we can just put the bages in the same position as we have them in the service overview, it should do the trick
- For the hover on the card I don't really like the bg-surface-neutral-subtle, I think the border change can be enough. If we want to accentuate it, we can also change the icon container to bg-surface-[semantic]-component on hover I think it could work
|
rmnbrd
requested changes
Apr 23, 2026
Contributor
rmnbrd
left a comment
rmnbrd
left a comment
There was a problem hiding this comment.
UI-wise, it looks good to me. But we're adding a lot of extra logic that, imo, should not be on the front-end.
Comment on lines
+125
to
+137
| const [hasRunningStatusTimedOut, setHasRunningStatusTimedOut] = useState(false) | ||
| useEffect(() => { | ||
| setHasRunningStatusTimedOut(false) | ||
| const timeoutId = setTimeout(() => setHasRunningStatusTimedOut(true), RUNNING_STATUS_TIMEOUT_MS) | ||
| return () => clearTimeout(timeoutId) | ||
| }, [runningStatusScopeKey]) | ||
|
|
||
| const runningStatusQueries = useClusterRunningStatuses({ clusters }) | ||
|
|
||
| // Keep the skeleton up until every cluster has reported a running status | ||
| // (real payload or explicit 'NotFound'), or the timeout fires as a safety net | ||
| const hasAllRunningStatuses = clusters.length === 0 || runningStatusQueries.every((query) => query.data !== undefined) | ||
| const isReady = hasAllRunningStatuses || hasRunningStatusTimedOut |
Contributor
There was a problem hiding this comment.
If I understand this part correctly, it seems like some back-end work could be done to avoid having this workaround on the front-end, right?
Comment on lines
+75
to
+110
| export function getClusterHealthIssues({ | ||
| cluster, | ||
| deploymentStatus, | ||
| runningStatus, | ||
| hasRunningStatusTimedOut, | ||
| }: GetClusterHealthIssuesInput): ClusterHealthIssueKind[] { | ||
| const issues: ClusterHealthIssueKind[] = [] | ||
|
|
||
| const status = deploymentStatus?.status | ||
| const isStopped = status === 'STOPPED' | ||
| const isDeployed = Boolean(deploymentStatus?.is_deployed) | ||
|
|
||
| if (status && FAILED_DEPLOYMENT_STATUSES.has(status)) { | ||
| issues.push('deploy-failed') | ||
| } | ||
|
|
||
| if (isDeployed && !isStopped) { | ||
| const isRunningStatusObject = runningStatus && typeof runningStatus === 'object' | ||
|
|
||
| if (isRunningStatusObject && runningStatus.computed_status?.global_status === 'ERROR') { | ||
| issues.push('running-error') | ||
| } | ||
|
|
||
| const isStatusUnavailable = runningStatus === 'NotFound' || (hasRunningStatusTimedOut && runningStatus == null) | ||
|
|
||
| if (isStatusUnavailable) { | ||
| issues.push('status-unavailable') | ||
| } | ||
| } | ||
|
|
||
| if (cluster.deployment_status === 'OUT_OF_DATE' && !isStopped) { | ||
| issues.push('update-available') | ||
| } | ||
|
|
||
| return issues | ||
| } |
Contributor
There was a problem hiding this comment.
To me, all of this logic should live on the back-end, not on the front-end
Member
Author
There was a problem hiding this comment.
Good point, I created a ticket for it https://qovery.atlassian.net/jira/software/c/projects/QOV/boards/55?assignee=712020%3A06ffe3b7-272d-4787-b750-04468533b84b&selectedIssue=QOV-1861
rmnbrd
approved these changes
Apr 24, 2026
…isplay with tooltip
…nd enhance performance with memoization
…Event and improve accessibility checks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2627 +/- ##
=================================================
Coverage ? 44.68%
=================================================
Files ? 729
Lines ? 17800
Branches ? 5263
=================================================
Hits ? 7954
Misses ? 8457
Partials ? 1389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add new cluster section for the organization overview
Screenshots / Recordings
https://www.loom.com/share/b64e51dad52b4289aebaf5ab7f770d17
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release