Skip to content

chore(console): remove legacy pages stack#2631

Merged
rmnbrd merged 20 commits intonew-navigationfrom
chore/new-nav/delete-legacy-files
Apr 27, 2026
Merged

chore(console): remove legacy pages stack#2631
rmnbrd merged 20 commits intonew-navigationfrom
chore/new-nav/delete-legacy-files

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Apr 24, 2026

Summary

This PR removes the legacy pages stack and finalizes the move to the current apps/console app structure.

What changed

  • removed the legacy apps/console-e2e app
  • removed libs/pages/**
  • renamed apps/console-v5 to apps/console
  • updated paths and build outputs accordingly
  • fixed broken imports/specs caused by the cleanup
  • fixed the last simple blocking lint error
  • SpotlightTrigger moved to libs/shared/spotlight/feature
  • PodLogsFeature moved to libs/domains/service-logs/feature

Remaining CI blockers

The simple lint issue is fixed.
The only remaining blocking errors are circular dependencies reported by @nx/enforce-module-boundaries.

domains-services-feature

  • select-version-modal.tsx (line 3)

    • cycle with domains-organizations-feature via shared-console-shared
    • chain: domains-services-feature -> domains-organizations-feature -> shared-console-shared -> domains-services-feature
  • service-deployment-list.tsx (line 16)

    • cycle with shared-devops-copilot-feature via shared-console-shared
    • chain: domains-services-feature -> shared-devops-copilot-feature -> shared-console-shared -> domains-services-feature
  • service-last-deployment-cell.tsx (line 4)

    • cycle with shared-devops-copilot-feature via shared-console-shared
    • chain: domains-services-feature -> shared-devops-copilot-feature -> shared-console-shared -> domains-services-feature

domains-environments-feature

  • settings-deployment-rules.tsx (line 5)

    • cycle with shared-console-shared
    • chain: domains-environments-feature -> shared-console-shared -> domains-environments-feature
  • settings-general.tsx (line 6)

    • cycle with shared-console-shared
    • chain: domains-environments-feature -> shared-console-shared -> domains-environments-feature
  • settings-preview-environments.tsx (line 7)

    • cycle with domains-services-feature
    • chain: domains-environments-feature -> domains-services-feature -> shared-devops-copilot-feature -> shared-console-shared -> domains-environments-feature
  • settings-preview-environments.tsx (line 8)

    • cycle with shared-console-shared
    • chain: domains-environments-feature -> shared-console-shared -> domains-environments-feature

shared-console-shared

  • add-credit-card-modal-feature.spec.tsx (line 3)

    • cycle with domains-organizations-feature
  • add-credit-card-modal-feature.tsx (line 4)

    • cycle with domains-organizations-feature
  • setting-resources-instance-types-feature.tsx (line 12)

    • cycle with domains-environments-feature
  • database-settings-resources.tsx (line 5)

    • cycle with domains-environments-feature
  • force-run-modal-feature.tsx (line 4)

    • cycle with domains-services-feature via shared-devops-copilot-feature
    • chain: shared-console-shared -> domains-services-feature -> shared-devops-copilot-feature -> shared-console-shared
  • github-application-callback-feature.tsx (line 3)

    • cycle with domains-organizations-feature

domains-organizations-feature

  • settings-api-token.tsx (line 4)
  • settings-billing-details.tsx (line 8)
  • settings-cloud-credentials.tsx (line 14)
  • settings-container-registries.tsx (line 4)
  • settings-general.tsx (line 7)
  • settings-git-repository-access.tsx (line 6)
  • settings-helm-repositories.tsx (line 4)
  • settings-labels-annotations.tsx (line 7)
  • settings-members.tsx (line 22)
  • settings-roles.tsx (line 5)
  • settings-webhook.tsx (line 4)

For all of the files above:

  • cycle with shared-console-shared

shared-devops-copilot-feature

  • ai-copilot-settings.tsx (line 4)
    • cycle with shared-console-shared via domains-services-feature
    • chain: shared-devops-copilot-feature -> shared-console-shared -> domains-services-feature -> shared-devops-copilot-feature

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet force-pushed the chore/new-nav/delete-legacy-files branch from 3a59b07 to b8c3b04 Compare April 24, 2026 14:06
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 52.21239% with 54 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@e2e198e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ib/add-credit-card-modal/add-credit-card-modal.tsx 48.83% 21 Missing and 1 partial ⚠️
...settings-resources/database-settings-resources.tsx 50.00% 9 Missing and 5 partials ⚠️
...eature/src/lib/force-run-modal/force-run-modal.tsx 64.86% 8 Missing and 5 partials ⚠️
...ter-creation-flow/step-summary/get-value-by-key.ts 0.00% 3 Missing ⚠️
...ture/src/lib/pod-logs-feature/pod-logs-feature.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2631   +/-   ##
=================================================
  Coverage                  ?   44.88%           
=================================================
  Files                     ?     1138           
  Lines                     ?    23804           
  Branches                  ?     6910           
=================================================
  Hits                      ?    10684           
  Misses                    ?    11241           
  Partials                  ?     1879           
Flag Coverage Δ
unittests 44.88% <52.21%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet marked this pull request as ready for review April 27, 2026 10:45
@RemiBonnet RemiBonnet requested a review from rmnbrd April 27, 2026 12:49
@rmnbrd rmnbrd merged commit d9adfb2 into new-navigation Apr 27, 2026
11 checks passed
@rmnbrd rmnbrd deleted the chore/new-nav/delete-legacy-files branch April 27, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants