chore(toast): migrate from react-hot-toast to sonner and remove shared toast library#2632
Merged
TheoGrandin74 merged 4 commits intonew-navigationfrom Apr 29, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2632 +/- ##
=================================================
Coverage ? 44.90%
=================================================
Files ? 1137
Lines ? 23789
Branches ? 6901
=================================================
Hits ? 10683
Misses ? 11233
Partials ? 1873
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…n and using a mapping object
1a2f200 to
99729c0
Compare
RemiBonnet
reviewed
Apr 28, 2026
RemiBonnet
approved these changes
Apr 28, 2026
Member
RemiBonnet
left a comment
There was a problem hiding this comment.
LGTM 👍
I feel it’s a bit too slow, I wonder if you could improve how fast it appear and disappear 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-hot-toastdependency and replaced it withsonnerfor toast notifications.shared/toastlibrary as it is no longer needed.Video
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release