Skip to content

fix(new-nav): env overview statuses glitch issue#2644

Merged
rmnbrd merged 1 commit into
new-navigationfrom
fix/new-nav/env-overview-status-glitch-QOV-1886
Apr 30, 2026
Merged

fix(new-nav): env overview statuses glitch issue#2644
rmnbrd merged 1 commit into
new-navigationfrom
fix/new-nav/env-overview-status-glitch-QOV-1886

Conversation

@rmnbrd
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd commented Apr 30, 2026

Summary

Issue: QOV-1886

UI inconsistency between the environment’s aggregated status and the individual service running statuses

Slack thread

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@rmnbrd rmnbrd changed the base branch from staging to new-navigation April 30, 2026 13:23
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.92%. Comparing base (598c863) to head (ac38f31).
⚠️ Report is 3 commits behind head on new-navigation.

Additional details and impacted files
@@               Coverage Diff               @@
##           new-navigation    #2644   +/-   ##
===============================================
  Coverage           44.92%   44.92%           
===============================================
  Files                1135     1135           
  Lines               23773    23773           
  Branches             6898     6898           
===============================================
  Hits                10679    10679           
  Misses              11221    11221           
  Partials             1873     1873           
Flag Coverage Δ
unittests 44.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd changed the title Fix/new nav/env overview status glitch qov 1886 fix(new-nav): env overview statuses glitch issue Apr 30, 2026
@rmnbrd rmnbrd marked this pull request as ready for review April 30, 2026 13:29
Copilot AI review requested due to automatic review settings April 30, 2026 13:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix a UI inconsistency in the Console where an environment’s aggregated status can become out of sync with individual service running statuses by adjusting how running-status React Query cache is handled during environment navigation.

Changes:

  • Add a React Query queryClient and a useEffect intended to clear the environment running-status cache to avoid stale data.
  • Introduce a wsEnabled flag to reuse the same enablement logic across both WS subscriptions.
  • Update React import to include useEffect.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rmnbrd rmnbrd requested a review from RemiBonnet April 30, 2026 13:43
@rmnbrd rmnbrd added the V5 label Apr 30, 2026
@rmnbrd rmnbrd self-assigned this Apr 30, 2026
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rmnbrd rmnbrd merged commit 676c401 into new-navigation Apr 30, 2026
15 of 19 checks passed
@rmnbrd rmnbrd deleted the fix/new-nav/env-overview-status-glitch-QOV-1886 branch April 30, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants