Skip to content

fix(ui): add several feedback#2646

Merged
RemiBonnet merged 12 commits into
new-navigationfrom
fix/new-nav/ui-feedback-4
May 4, 2026
Merged

fix(ui): add several feedback#2646
RemiBonnet merged 12 commits into
new-navigationfrom
fix/new-nav/ui-feedback-4

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Apr 30, 2026

Summary

  • Add "all clusters" link in the organization overview (slack) + fix feature flag (slack)
  • Add brand color for "update" for the production cluster modal in the organization overview + update modal wording (slack)
  • Fix link error monitoring card to service logs (slack)
  • Fix AM/PM for deployment dates (slack)
  • Fix Changelog generation
  • Fix drunk spinner (slack)
  • Add click on row to access deployment details (slack)

Screenshots / Recordings

Screenshot 2026-04-30 at 16 56 27 Screenshot 2026-04-30 at 16 56 34

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 81.33333% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.26%. Comparing base (598c863) to head (7324c66).
⚠️ Report is 5 commits behind head on new-navigation.

Files with missing lines Patch % Lines
...nt-deployment-list/environment-deployment-list.tsx 69.56% 6 Missing and 1 partial ⚠️
...ervice-deployment-list/service-deployment-list.tsx 70.83% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2646      +/-   ##
==================================================
- Coverage           44.92%   44.26%   -0.66%     
==================================================
  Files                1135      677     -458     
  Lines               23773    16835    -6938     
  Branches             6898     4987    -1911     
==================================================
- Hits                10679     7452    -3227     
+ Misses              11221     8050    -3171     
+ Partials             1873     1333     -540     
Flag Coverage Δ
unittests 44.26% <81.33%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet marked this pull request as ready for review April 30, 2026 15:41
</Heading>
<div className="flex items-center justify-between gap-3">
<Heading className="flex items-center gap-2">
{clusterProduction.length > 0 ? 'Your production health' : 'Production health'}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this, it doesn't make much sense to have two different wording for the empty state and the fill state. I think we can simplify and just have "Production health"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 70b5125

RemiBonnet added 6 commits May 4, 2026 09:10
…e formatting to remove AM/PM notation in deployment timestamps
…details and add HTML parsing functions for changelog synchronization
…ng.fromCodePoint for better Unicode support and format regex for readability
…actions, service-deployment-list): wrap loader icons in a span for consistent styling and alignment
…w navigation handling and add tests for deployment row clicks
…or running status issues and update related tests
@RemiBonnet RemiBonnet merged commit b3b67ea into new-navigation May 4, 2026
11 checks passed
@RemiBonnet RemiBonnet deleted the fix/new-nav/ui-feedback-4 branch May 4, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants