Skip to content

fix(new-nav): fix keda cluster settings#2650

Merged
RemiBonnet merged 1 commit into
new-navigationfrom
fix/new-nav-keda
May 4, 2026
Merged

fix(new-nav): fix keda cluster settings#2650
RemiBonnet merged 1 commit into
new-navigationfrom
fix/new-nav-keda

Conversation

@pggb25
Copy link
Copy Markdown
Collaborator

@pggb25 pggb25 commented May 4, 2026

Summary

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet changed the title fix:(new-nav): fix keda cluster settings fix(new-nav): fix keda cluster settings May 4, 2026
@pggb25 pggb25 force-pushed the fix/new-nav-keda branch from 53f8413 to 77924ef Compare May 4, 2026 11:44
@RemiBonnet RemiBonnet merged commit 48ecf22 into new-navigation May 4, 2026
10 checks passed
@RemiBonnet RemiBonnet deleted the fix/new-nav-keda branch May 4, 2026 11:54
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (new-navigation@440215a). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2650   +/-   ##
=================================================
  Coverage                  ?   42.31%           
=================================================
  Files                     ?      473           
  Lines                     ?    12384           
  Branches                  ?     3732           
=================================================
  Hits                      ?     5240           
  Misses                    ?     6201           
  Partials                  ?      943           
Flag Coverage Δ
unittests 42.31% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants