Skip to content

feat(cluster-status): add status in the service list, cluster/service overview#2651

Merged
RemiBonnet merged 4 commits into
new-navigationfrom
fix/new-nav/cluster-status
May 4, 2026
Merged

feat(cluster-status): add status in the service list, cluster/service overview#2651
RemiBonnet merged 4 commits into
new-navigationfrom
fix/new-nav/cluster-status

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented May 4, 2026

Summary

Slack

I added the cluster status to the cluster overview, the service overview, and the service list.
For the cluster overview, I kept the same badge format that we use in the cluster list.

Screenshots / Recordings

Screenshot 2026-05-04 at 15 01 39 Screenshot 2026-05-04 at 15 01 51 Screenshot 2026-05-04 at 15 02 00 Screenshot 2026-05-04 at 15 02 09

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet force-pushed the fix/new-nav/cluster-status branch from d26e285 to 74ebed0 Compare May 4, 2026 13:13
@RemiBonnet RemiBonnet marked this pull request as ready for review May 4, 2026 13:13
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 6.25000% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.33%. Comparing base (48ecf22) to head (3813679).
⚠️ Report is 2 commits behind head on new-navigation.

Files with missing lines Patch % Lines
...tus-indicator/cluster-running-status-indicator.tsx 3.33% 27 Missing and 2 partials ⚠️
...service-overview/service-header/service-header.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2651      +/-   ##
==================================================
- Coverage           45.03%   44.33%   -0.70%     
==================================================
  Files                1135      677     -458     
  Lines               23836    16839    -6997     
  Branches             6923     4998    -1925     
==================================================
- Hits                10734     7466    -3268     
+ Misses              11230     8034    -3196     
+ Partials             1872     1339     -533     
Flag Coverage Δ
unittests 44.33% <6.25%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@RemiBonnet RemiBonnet merged commit d9a7e6d into new-navigation May 4, 2026
10 of 11 checks passed
@RemiBonnet RemiBonnet deleted the fix/new-nav/cluster-status branch May 4, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants