fix(new-nav): look of the "ctrl k" button#2653
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the shared <Kbd> UI component and the Spotlight search trigger so the “Ctrl K” hint renders with correct sizing and spacing across platforms.
Changes:
- Adjust
<Kbd>base styling to usemin-w-4instead of a fixedw-4, allowing longer key labels (e.g., “Ctrl”) to fit. - Refine Spotlight trigger hotkey styling with padding and platform-specific font sizing for the meta key label.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
libs/shared/ui/src/lib/components/kbd/kbd.tsx |
Makes <Kbd> flexible-width by default via min-w-4 while keeping a consistent minimum size. |
libs/shared/spotlight/feature/src/lib/spotlight-trigger/spotlight-trigger.tsx |
Tunes the “meta + k” hint styling (padding + font size adjustments) to improve the “Ctrl K” button look. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2653 +/- ##
==================================================
- Coverage 45.03% 44.53% -0.50%
==================================================
Files 1135 1076 -59
Lines 23836 22839 -997
Branches 6923 6658 -265
==================================================
- Hits 10734 10171 -563
+ Misses 11230 10906 -324
+ Partials 1872 1762 -110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
PR fixing the look of the "ctrl K" button.
Slack thread
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release