Skip to content

fix(new-nav): look of the "ctrl k" button#2653

Merged
rmnbrd merged 1 commit into
new-navigationfrom
fix/new-nav/ctrl-k-button
May 4, 2026
Merged

fix(new-nav): look of the "ctrl k" button#2653
rmnbrd merged 1 commit into
new-navigationfrom
fix/new-nav/ctrl-k-button

Conversation

@rmnbrd
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd commented May 4, 2026

Summary

PR fixing the look of the "ctrl K" button.

Slack thread

Screenshots / Recordings

Screenshot 2026-05-04 at 15 21 34

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@rmnbrd rmnbrd self-assigned this May 4, 2026
@rmnbrd rmnbrd added the V5 label May 4, 2026
@rmnbrd rmnbrd marked this pull request as ready for review May 4, 2026 13:32
Copilot AI review requested due to automatic review settings May 4, 2026 13:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the shared <Kbd> UI component and the Spotlight search trigger so the “Ctrl K” hint renders with correct sizing and spacing across platforms.

Changes:

  • Adjust <Kbd> base styling to use min-w-4 instead of a fixed w-4, allowing longer key labels (e.g., “Ctrl”) to fit.
  • Refine Spotlight trigger hotkey styling with padding and platform-specific font sizing for the meta key label.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
libs/shared/ui/src/lib/components/kbd/kbd.tsx Makes <Kbd> flexible-width by default via min-w-4 while keeping a consistent minimum size.
libs/shared/spotlight/feature/src/lib/spotlight-trigger/spotlight-trigger.tsx Tunes the “meta + k” hint styling (padding + font size adjustments) to improve the “Ctrl K” button look.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 44.53%. Comparing base (48ecf22) to head (4da836e).
⚠️ Report is 1 commits behind head on new-navigation.

Files with missing lines Patch % Lines
...re/src/lib/spotlight-trigger/spotlight-trigger.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2653      +/-   ##
==================================================
- Coverage           45.03%   44.53%   -0.50%     
==================================================
  Files                1135     1076      -59     
  Lines               23836    22839     -997     
  Branches             6923     6658     -265     
==================================================
- Hits                10734    10171     -563     
+ Misses              11230    10906     -324     
+ Partials             1872     1762     -110     
Flag Coverage Δ
unittests 44.53% <0.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd merged commit 585ce0d into new-navigation May 4, 2026
16 checks passed
@rmnbrd rmnbrd deleted the fix/new-nav/ctrl-k-button branch May 4, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants