feat(layout): update height calculations for page containers#2657
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2657 +/- ##
==================================================
- Coverage 45.08% 38.38% -6.70%
==================================================
Files 1135 89 -1046
Lines 23841 2845 -20996
Branches 6935 931 -6004
==================================================
- Hits 10748 1092 -9656
+ Misses 11215 1502 -9713
+ Partials 1878 251 -1627
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rmnbrd
approved these changes
May 5, 2026
Contributor
rmnbrd
left a comment
There was a problem hiding this comment.
Looks good to me, well done 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix double scroll when organization banners are visible on standard-size screens.
The page container height now accounts for the rendered banner height, and logs/cloud-shell views use the shared page-container sizing instead of hardcoded viewport calculations. This keeps service logs, deployment logs, cluster logs, and terminals to a single intended scroll area on smaller screens
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release