Skip to content

feat(layout): update height calculations for page containers#2657

Merged
RemiBonnet merged 1 commit into
new-navigationfrom
fix/new-nav/layout-scroll
May 5, 2026
Merged

feat(layout): update height calculations for page containers#2657
RemiBonnet merged 1 commit into
new-navigationfrom
fix/new-nav/layout-scroll

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented May 5, 2026

Summary

Fix double scroll when organization banners are visible on standard-size screens.

The page container height now accounts for the rendered banner height, and logs/cloud-shell views use the shared page-container sizing instead of hardcoded viewport calculations. This keeps service logs, deployment logs, cluster logs, and terminals to a single intended scroll area on smaller screens

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet added the V5 label May 5, 2026
@RemiBonnet RemiBonnet marked this pull request as ready for review May 5, 2026 09:52
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.38%. Comparing base (b976b45) to head (97a5603).

Files with missing lines Patch % Lines
...re/src/lib/list-service-logs/list-service-logs.tsx 0.00% 21 Missing ⚠️
.../lib/list-deployment-logs/list-deployment-logs.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           new-navigation    #2657      +/-   ##
==================================================
- Coverage           45.08%   38.38%   -6.70%     
==================================================
  Files                1135       89    -1046     
  Lines               23841     2845   -20996     
  Branches             6935      931    -6004     
==================================================
- Hits                10748     1092    -9656     
+ Misses              11215     1502    -9713     
+ Partials             1878      251    -1627     
Flag Coverage Δ
unittests 38.38% <0.00%> (-6.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, well done 👏

@RemiBonnet RemiBonnet merged commit f6748dd into new-navigation May 5, 2026
12 of 13 checks passed
@RemiBonnet RemiBonnet deleted the fix/new-nav/layout-scroll branch May 5, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants