feat(QOV-1891): add cluster DNS provider settings.#2674
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2674 +/- ##
===========================================
+ Coverage 43.73% 46.14% +2.41%
===========================================
Files 591 1150 +559
Lines 14532 23960 +9428
Branches 4264 6974 +2710
===========================================
+ Hits 6355 11056 +4701
- Misses 7046 10954 +3908
- Partials 1131 1950 +819
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rmnbrd
requested changes
May 11, 2026
| const { mutateAsync: editClusterDnsProvider, isLoading: isEditClusterDnsProviderLoading } = | ||
| useEditClusterDnsProvider() | ||
|
|
||
| const isLoading = isOrganizationLoading || isClusterDnsProviderLoading |
Contributor
There was a problem hiding this comment.
Instead of manually dealing with loading states, can you use React Suspense?
You can take example on this component:
000cbd1 to
8aa020a
Compare
rmnbrd
reviewed
May 13, 2026
Description: Add DNS provider settings page in the new cluster navigation Support Qovery, Cloudflare, and Route53 configuration Gate editing behind Enterprise plan and keep non-Enterprise view read-only Use generated API client for DNS provider GET/PUT calls
8aa020a to
6692d4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add DNS provider settings page in the new cluster navigation
Support Qovery, Cloudflare, and Route53 configuration
Gate editing behind Enterprise plan and keep non-Enterprise view read-only
Use generated API client for DNS provider GET/PUT calls
more info here:
https://qovery.slack.com/archives/C090J2C2BUP/p1778051436737839
Issue:
Issue:
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release