Skip to content

fix(audit logs): improve dropdown state management and animations#2688

Merged
RemiBonnet merged 1 commit into
stagingfrom
fix/audit-logs-filters
May 15, 2026
Merged

fix(audit logs): improve dropdown state management and animations#2688
RemiBonnet merged 1 commit into
stagingfrom
fix/audit-logs-filters

Conversation

@TheoGrandin74
Copy link
Copy Markdown
Contributor

@TheoGrandin74 TheoGrandin74 commented May 15, 2026

Summary

  • Fixed a bug in the Audit logs where we needed to click two times on each filters to open the dropdown
  • Harmonized the dropdown opening animation with the one we have on the calendar dropdown in the same page for consistency

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.73%. Comparing base (582207d) to head (72a6a29).

Files with missing lines Patch % Lines
...le/table-head-datepicker/table-head-datepicker.tsx 16.66% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2688      +/-   ##
===========================================
- Coverage    45.21%   44.73%   -0.49%     
===========================================
  Files         1153     1093      -60     
  Lines        24121    23119    -1002     
  Branches      7027     6761     -266     
===========================================
- Hits         10907    10342     -565     
+ Misses       11310    10985     -325     
+ Partials      1904     1792     -112     
Flag Coverage Δ
unittests 44.73% <44.44%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet merged commit 73c0d81 into staging May 15, 2026
17 checks passed
@RemiBonnet RemiBonnet deleted the fix/audit-logs-filters branch May 15, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants