feat(cluster): add secret manager creation step#2719
Open
rmnbrd wants to merge 1 commit into
Open
Conversation
12 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an add-ons step to the cluster creation flow for managed AWS/GCP clusters, wiring KEDA and secret manager configuration into context, summary display, routing, and create-cluster payloads.
Changes:
- Adds
ClusterAddonsDatato cluster creation context and inserts anaddonsstep for managed AWS/GCP flows. - Introduces the add-ons UI with KEDA toggle and secret manager integration management.
- Updates routing, summary rendering, payload creation, exports, and related tests/mocks.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary.tsx |
Adds add-ons payload wiring, feature flag use, summary navigation, and add-ons props. |
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary.spec.tsx |
Adds PostHog mock and add-ons context defaults. |
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary-presentation.tsx |
Displays KEDA and secret manager add-ons in the summary. |
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-summary/step-summary-presentation.spec.tsx |
Updates default props for add-ons summary support. |
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-resources/step-resources.spec.tsx |
Adds add-ons context defaults to test setup. |
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-general/step-general.tsx |
Sets the current funnel step for the general step. |
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-general/step-general.spec.tsx |
Adds add-ons context defaults to test setup. |
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-features/step-features.spec.tsx |
Adds add-ons context defaults to test setup. |
libs/domains/clusters/feature/src/lib/cluster-creation-flow/step-addons/step-addons.tsx |
Adds the new add-ons step UI and state synchronization. |
libs/domains/clusters/feature/src/lib/cluster-creation-flow/cluster-creation-flow.tsx |
Extends creation context and step definitions for add-ons. |
libs/domains/clusters/feature/src/lib/cluster-creation-flow/cluster-creation-flow.spec.tsx |
Updates step expectations for AWS/GCP add-ons flow. |
libs/domains/clusters/feature/src/index.ts |
Exports the new add-ons step. |
apps/console/src/routeTree.gen.ts |
Registers the generated add-ons route. |
apps/console/src/routes/_authenticated/organization/$organizationId/cluster/create/$slug/features.tsx |
Routes AWS/GCP feature submission to add-ons before summary. |
apps/console/src/routes/_authenticated/organization/$organizationId/cluster/create/$slug/addons.tsx |
Adds the console route for the add-ons step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| useEffect(() => { | ||
| if (!generalData?.name) { | ||
| if (!generalData) { |
| {showSecretManagerSummary && props.addonsData.secretManagers.length > 0 && ( | ||
| <div className="mt-3 space-y-3 border-t border-neutral pt-3 text-sm text-neutral-subtle"> | ||
| {props.addonsData.secretManagers.map((manager, index) => ( | ||
| <div key={manager.id} className="space-y-3"> |
Comment on lines
+52
to
+56
| useEffect(() => { | ||
| setAddonsData({ | ||
| kedaActivated: kedaEnabled, | ||
| secretManagers: secretManagerEnabled ? integrations : [], | ||
| }) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/secrets-manager-cluster-settings #2719 +/- ##
=========================================================================
- Coverage 46.07% 45.58% -0.50%
=========================================================================
Files 1187 707 -480
Lines 24831 17731 -7100
Branches 7306 5338 -1968
=========================================================================
- Hits 11442 8082 -3360
+ Misses 11407 8198 -3209
+ Partials 1982 1451 -531
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds secret manager configuration to the cluster creation flow, including the add-ons step, creation context data, summary display, and payload wiring.
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release