Skip to content

fix(modal): Add fakeModal props to git token modal for popover actions#2722

Merged
rmnbrd merged 1 commit into
stagingfrom
fix/links-popover-on-modal
Jun 1, 2026
Merged

fix(modal): Add fakeModal props to git token modal for popover actions#2722
rmnbrd merged 1 commit into
stagingfrom
fix/links-popover-on-modal

Conversation

@TheoGrandin74
Copy link
Copy Markdown
Contributor

Summary

Tint bug report here, fix on a popover bug where we could not click on the link on it

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@TheoGrandin74 TheoGrandin74 changed the title Add fakeModal props to git token modal for popover actions fix(git token modal) Add fakeModal props to git token modal for popover actions Jun 1, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.09%. Comparing base (ca77a24) to head (aa77851).

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2722      +/-   ##
===========================================
- Coverage    46.95%   44.09%   -2.86%     
===========================================
  Files         1165      597     -568     
  Lines        24414    14669    -9745     
  Branches      7173     4348    -2825     
===========================================
- Hits         11463     6468    -4995     
+ Misses       10950     7059    -3891     
+ Partials      2001     1142     -859     
Flag Coverage Δ
unittests 44.09% <ø> (-2.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TheoGrandin74 TheoGrandin74 changed the title fix(git token modal) Add fakeModal props to git token modal for popover actions fix(modal): Add fakeModal props to git token modal for popover actions Jun 1, 2026
@rmnbrd rmnbrd merged commit c3d5730 into staging Jun 1, 2026
11 of 15 checks passed
@rmnbrd rmnbrd deleted the fix/links-popover-on-modal branch June 1, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants