Replace QReg by IList[Qubit, Any] #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
weinbe58
approved these changes
Apr 22, 2025
Member
weinbe58
left a comment
weinbe58
left a comment
There was a problem hiding this comment.
Just update that RuntimeError to an InterpreterError and then feel free to merge.
| cbit.set_value(Measurement(qubit.sim_reg.m(qubit.addr))) | ||
| else: | ||
| cbit.set_value(interp.loss_m_result) | ||
| else: |
Member
There was a problem hiding this comment.
oh BTW I missed this in the last PR, you should raise an InterpreterError here not a RuntimeError.
Member
There was a problem hiding this comment.
specifically in the else branch here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #153
Also related:
#160 #161 #162
FYI, @cduck