Skip to content

Conversation

@kaihsin
Copy link
Contributor

@kaihsin kaihsin commented Apr 24, 2025

This PR fix qasm2 codegen issue related to custom gate subroutine lowering.

@kaihsin
Copy link
Contributor Author

kaihsin commented Apr 24, 2025

address #201

@kaihsin kaihsin requested review from Roger-luo and weinbe58 April 24, 2025 21:54
@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
6188 5312 86% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/bloqade/qasm2/dialects/expr/_emit.py 79% 🟢
src/bloqade/qasm2/emit/gate.py 84% 🟢
src/bloqade/qasm2/emit/target.py 100% 🟢
TOTAL 88% 🟢

updated for commit: fb24b62 by action🐍

Copy link
Collaborator

@Roger-luo Roger-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast.

Copy link
Member

@weinbe58 weinbe58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have time to review this so don't wait for me.

@weinbe58 weinbe58 merged commit 14f89ba into main Apr 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants