Skip to content

Conversation

@david-pl
Copy link
Collaborator

No description provided.

@weinbe58 weinbe58 self-assigned this Nov 19, 2025
Copy link
Member

@weinbe58 weinbe58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Roger-luo
Copy link
Collaborator

CI is not passing?

Copy link
Contributor

@zhenrongliew zhenrongliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@zhenrongliew
Copy link
Contributor

CI is not passing?

The CI is complaining about ValidationErrorGroup which is blocked by this Kirin PR.

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
10173 8931 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/bloqade/gemini/analysis/logical_validation/init.py 100% 🟢
src/bloqade/gemini/analysis/logical_validation/analysis.py 100% 🟢
src/bloqade/gemini/analysis/logical_validation/impls.py 100% 🟢
src/bloqade/gemini/dialects/logical/groups.py 96% 🟢
TOTAL 99% 🟢

updated for commit: f5ca8ef by action🐍

@david-pl david-pl merged commit 5b853b7 into main Nov 25, 2025
9 of 10 checks passed
@david-pl david-pl deleted the david/refactor-gemini-validation branch November 25, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants