-
Notifications
You must be signed in to change notification settings - Fork 1
Adding typeinfer from grid.New statement.
#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| from typing import cast | ||
|
|
||
| from kirin import types | ||
| from kirin.analysis import TypeInference | ||
| from kirin.dialects import ilist | ||
| from kirin.interp import Frame, MethodTable, impl | ||
|
|
||
| from ._dialect import dialect | ||
| from .stmts import New | ||
| from .types import GridType | ||
|
|
||
|
|
||
| @dialect.register(key="typeinfer") | ||
| class TypeInferMethods(MethodTable): | ||
|
|
||
| def get_len(self, typ: types.TypeAttribute): | ||
| if typ.is_subseteq(ilist.IListType[types.Int, types.Any]): | ||
| typ = cast(types.Generic, typ) | ||
| if isinstance(typ.vars[1], types.Literal): | ||
| return types.Literal(typ.vars[1].data + 1) | ||
|
|
||
| return types.Any | ||
|
|
||
| @impl(New) | ||
| def inter_new(self, _: TypeInference, frame: Frame[types.TypeAttribute], node: New): | ||
| x_len = self.get_len(frame.get(node.x_spacing)) | ||
| y_len = self.get_len(frame.get(node.y_spacing)) | ||
|
|
||
| return (GridType[x_len, y_len],) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| from kirin import ir | ||
| from kirin.ir.method import Method | ||
| from kirin.passes.default import Default | ||
| from kirin.prelude import structural | ||
| from typing_extensions import Annotated, Doc | ||
|
|
||
| from bloqade.geometry.dialects import grid | ||
|
|
||
|
|
||
| @ir.dialect_group(structural.add(grid)) | ||
| def geometry( | ||
| self, | ||
| ): | ||
| """Structural kernel with optimization passes.""" | ||
|
|
||
| def run_pass( | ||
| mt: Annotated[Method, Doc("The method to run pass on.")], | ||
| *, | ||
| verify: Annotated[ | ||
| bool, Doc("run `verify` before running passes, default is `True`") | ||
| ] = True, | ||
| typeinfer: Annotated[ | ||
| bool, | ||
| Doc( | ||
| "run type inference and apply the inferred type to IR, default `False`" | ||
| ), | ||
| ] = False, | ||
| fold: Annotated[bool, Doc("run folding passes")] = True, | ||
| aggressive: Annotated[ | ||
| bool, Doc("run aggressive folding passes if `fold=True`") | ||
| ] = False, | ||
| no_raise: Annotated[bool, Doc("do not raise exception during analysis")] = True, | ||
| ) -> None: | ||
| default_pass = Default( | ||
| self, | ||
| verify=verify, | ||
| fold=fold, | ||
| aggressive=aggressive, | ||
| typeinfer=typeinfer, | ||
| no_raise=no_raise, | ||
| ) | ||
| default_pass.fixpoint(mt) | ||
|
|
||
| return run_pass |
Empty file.
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| from kirin import types | ||
|
|
||
| from bloqade.geometry.dialects import grid | ||
| from bloqade.geometry.prelude import geometry | ||
|
|
||
|
|
||
| def test_typeinfer(): | ||
|
|
||
| @geometry | ||
| def test_method(): | ||
| return grid.New([1, 2], [1, 2], 0, 0) | ||
|
|
||
| test_method.return_type.is_equal(grid.GridType[types.Literal(3), types.Literal(3)]) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| test_typeinfer() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The get_len function checks for a list of integers while grid.New declares spacing as a list of floats. Verify that this discrepancy is intentional or update the types to ensure consistency in type inference.