Fix length check in typeinfer. #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix the length check in type inference by updating the condition in the get_len method. The key change is the consolidation of the type check and cast into a single inline expression.
- Inline casting with the walrus operator to streamline the condition.
- Adjustment of the is_subseteq check to work with the updated cast.
Comment on lines
+17
to
+19
| if (typ := cast(types.Generic, typ)).is_subseteq( | ||
| ilist.IListType | ||
| ) and isinstance(typ.vars[1], types.Literal): |
There was a problem hiding this comment.
[nitpick] Using the inline cast with the walrus operator may reduce readability if 'typ' is not clearly expected to be a 'types.Generic'. Consider adding a comment to clarify the assumption or splitting the expression to improve maintainability.
Suggested change
| if (typ := cast(types.Generic, typ)).is_subseteq( | |
| ilist.IListType | |
| ) and isinstance(typ.vars[1], types.Literal): | |
| # Assume 'typ' is a 'types.Generic' for the purpose of this method. | |
| typ = cast(types.Generic, typ) | |
| if typ.is_subseteq(ilist.IListType) and isinstance(typ.vars[1], types.Literal): |
weinbe58
added a commit
that referenced
this pull request
May 9, 2025
* fixing type infer * removing the subtype * refactor * Adding comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.