make index typing less strict #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes index typing less strict by allowing sequences of integers in addition to int, slice, and IList types. It also adds two new convenience functions to the public API for accessing grid position data.
- Adds support for accepting any
Sequenceof integers as an index inget_indices() - Exports
col_yposandrow_xposfunctions for accessing column and row positions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/bloqade/geometry/dialects/grid/types.py |
Extends get_indices() to accept generic sequences of integers, making indexing more flexible |
src/bloqade/geometry/dialects/grid/__init__.py |
Exports col_ypos and row_xpos functions to the public API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
weinbe58
added a commit
that referenced
this pull request
Dec 5, 2025
* make index typing less strict * IList is Sequence so just use Sequence check * make more generic * Adding test to check error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.