Refactoring AST lowering transform#343
Merged
Merged
Conversation
Contributor
|
Roger-luo
added
category: breaking change
Roger-luo
changed the title
Roger-luo
changed the title
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
This was referenced Apr 2, 2025
Closed
Roger-luo
added a commit
that referenced
this pull request
Apr 5, 2025
finally decide to just do it... gonna supercede #315 This PR refactors the AST lowering framework to make it more generic. So that other langauge AST can reuse the framework to generate SSA IR (e.g QASM2, etc.). We will also try to clean up the APIs in the process. ### Highlights - new error message of lowering <img width="682" alt="image" src="https://github.com/user-attachments/assets/b5591b7a-a3dc-44fa-b977-538a2049d691" /> - removing the `push_frame` and `pop_frame` in `lowering.State`. Now you can just write ```python with state.frame(stmts) as body_frame: ... ``` The main changes are mostly splitting the APIs into several classes. We still need to improve the precision of error reports here, but we will do that in a few following PRs. cc: @weinbe58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finally decide to just do it... gonna supercede #315
This PR refactors the AST lowering framework to make it more generic. So that other langauge AST can reuse the framework to generate SSA IR (e.g QASM2, etc.). We will also try to clean up the APIs in the process.
Highlights
push_frameandpop_frameinlowering.State. Now you can just writeThe main changes are mostly splitting the APIs into several classes. We still need to improve the precision of error reports here, but we will do that in a few following PRs.
cc: @weinbe58