Skip to content

Conversation

@zhenrongliew
Copy link
Contributor

Updated the raise_if_invalid method to raise an ExceptionGroup containing all validation errors, with a formatted message for better clarity.
Addressing this issue.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11624 10357 89% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 61ce3f1 by action🐍

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-11-19 16:10 UTC

@Roger-luo Roger-luo merged commit 7982391 into main Nov 19, 2025
13 checks passed
@Roger-luo Roger-luo deleted the dl/validationresult-raise-all branch November 19, 2025 16:09
@david-pl
Copy link
Contributor

@zhenrongliew but does this still pretty-print the errors? When I was working on this, using python's native ExceptionGroup didn't nicely print the ir.ValidationError output, so it's not easy to see the line numbers etc. That's why I went for a dedicated class along with an error handler here: https://github.com/QuEraComputing/bloqade-circuit/blob/d29a1c31f7744f2075dd76732a808e780fba8e51/src/bloqade/validation/kernel_validation.py#L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants