Skip to content

Make MethodType explicit #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 20, 2025
Merged

Make MethodType explicit #582

merged 11 commits into from
Nov 20, 2025

Conversation

@kaihsin
Copy link
Collaborator

@kaihsin kaihsin commented Nov 19, 2025

This PR address #579 and contain partly of #580

@kaihsin kaihsin requested a review from Roger-luo November 19, 2025 21:12
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025 •
edited
Loading

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-11-20 17:25 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11712 10447 89% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/kirin/analysis/typeinfer/solve.py 85% 🟢
src/kirin/dialects/func/_init_.py 100% 🟢
src/kirin/dialects/func/attrs.py 81% 🟢
src/kirin/dialects/func/stmts.py 94% 🟢
src/kirin/dialects/func/typeinfer.py 90% 🟢
src/kirin/dialects/ilist/stmts.py 99% 🟢
src/kirin/dialects/lowering/func.py 95% 🟢
src/kirin/ir/attrs/types.py 87% 🟢
src/kirin/ir/method.py 95% 🟢
src/kirin/types.py 100% 🟢
TOTAL 93% 🟢

updated for commit: 069d743 by action🐍

@codecov
Copy link

codecov bot commented Nov 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.98413% with 29 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/kirin/ir/attrs/types.py 72.52% 25 Missing ⚠️
src/kirin/analysis/typeinfer/solve.py 76.47% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

Roger-luo
Roger-luo reviewed Nov 19, 2025
View reviewed changes
src/kirin/dialects/func/attrs.py Outdated
MethodType = types.Generic(
Method, types.TypeVar("Params", types.Tuple), types.TypeVar("Ret")
)
# TypeofMethodType = types.PyClass[Method]
Copy link
Collaborator

@Roger-luo Roger-luo Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of the Signature attribute too? Now you have a function type we can just use that to replace the Signature attribute

Copy link
Collaborator Author

@kaihsin kaihsin Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that will be breaking tho because it requires to remove the trait too

Copy link
Collaborator Author

@kaihsin kaihsin Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my original thought is that trait change can go together with your refactor on stage method, and make this PR simpler

Roger-luo
Roger-luo requested changes Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@Roger-luo Roger-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should be good in general, need to fix a few linting bugs I had in #580

@kaihsin kaihsin added bug Something isn't working priority: high high priority, blocking milestones, time sensitive labels Nov 19, 2025
@kaihsin
Copy link
Collaborator Author

kaihsin commented Nov 20, 2025

I think should be good in general, need to fix a few linting bugs I had in #580

fixed type hint issue

@Roger-luo
Copy link
Collaborator

Roger-luo commented Nov 20, 2025

Oh nice, glad you figure it out!

@Roger-luo Roger-luo added the breaking breaking changes or proposed changes that would break existing APIs label Nov 20, 2025
@Roger-luo Roger-luo merged commit 5d4b0f8 into main Nov 20, 2025
12 of 13 checks passed
@Roger-luo Roger-luo deleted the khwu/method_type branch November 20, 2025 17:24
This was referenced Nov 25, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Roger-luo Roger-luo Roger-luo requested changes

Assignees

No one assigned

Labels

breaking breaking changes or proposed changes that would break existing APIs bug Something isn't working priority: high high priority, blocking milestones, time sensitive

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaihsin @Roger-luo