Lowering for syntax sugar for binop #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This should be non-breaking as its an (optional) enhancement |
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Roger-luo
approved these changes
Nov 25, 2025
kaihsin
added a commit
that referenced
this pull request
Nov 25, 2025
This PR expand the capability for lowering of kernel with type hint of something with: ```python @basic def main(x: str | float | int): return x main.print() tps = main.arg_types assert len(tps) == 1 assert tps[0] == types.Union([types.String, types.Float, types.Int]) ``` Note that before this PR, only Binding can allow this semantic, but will error if one trying to do that for kernel program
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expand the capability for lowering of kernel with type hint of something with:
Note that before this PR, only Binding can allow this semantic, but will error if one trying to do that for kernel program