Skip to content

fix(types.py): Addint is_subseteq_TypeVar to FunctionType to make sure it will be compabitle with generics#657

Merged
Roger-luo merged 2 commits into
mainfrom
phil/fix-missing-typeattr
May 26, 2026
Merged

fix(types.py): Addint is_subseteq_TypeVar to FunctionType to make sure it will be compabitle with generics#657
Roger-luo merged 2 commits into
mainfrom
phil/fix-missing-typeattr

Conversation

@weinbe58
Copy link
Copy Markdown
Member

Related issue #656 The problem there is when the FunctionType interaces with the IList Generic type it exposed that we're missing a visitor for is_subseteq_TypeVar because during lowering we haven't inferred the type yet.

@weinbe58 weinbe58 requested a review from kaihsin May 22, 2026 20:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
11650 10488 90% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/kirin/ir/attrs/types.py 87% 🟢
TOTAL 87% 🟢

updated for commit: 24f626a by action🐍

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-05-26 13:58 UTC

@kaihsin
Copy link
Copy Markdown
Collaborator

kaihsin commented May 25, 2026

cc @paige-quera @cduck

@Roger-luo Roger-luo merged commit 54ea95c into main May 26, 2026
13 checks passed
@Roger-luo Roger-luo deleted the phil/fix-missing-typeattr branch May 26, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants