Require gfni target feature for the AVX-512 codepath #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boosts some of the benchmarks by 50% on Zen 4. This instruction first appeared in 2019: https://en.wikipedia.org/wiki/Sunny_Cove_(microarchitecture) Intel docs: https://builders.intel.com/docs/networkbuilders/galois-field-new-instructions-gfni-technology-guide-1-1639042826.pdf On CPUs from before 2019 it's usually not worth it to use AVX-512 anyway because of the severe downlocking it induces.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 12 12
Lines 2167 2167
=======================================
Hits 2149 2149
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boosts some of the benchmarks by 50% on Zen 4.
This instruction first appeared in 2019: https://en.wikipedia.org/wiki/Sunny_Cove_(microarchitecture)
Intel docs: https://builders.intel.com/docs/networkbuilders/galois-field-new-instructions-gfni-technology-guide-1-1639042826.pdf
On CPUs from before 2019 it's usually not worth it to use AVX-512 anyway because of the severe downlocking it induces.
Fixes #40