Conversation
rturrado
left a comment
There was a problem hiding this comment.
Beautiful!
My only question would be the utils/check_passes name. I would usually go for sustantives more than verbs for folder names, e.g., utils/checks or utils/passes (even utils/passes_checks, but I don't really like that one). We could even leave it like utils/check_mapper.py until we have more things within utils.
Thanks!
|
I agree with @rturrado to use nouns (sustantivos in Spanish 😅) for folder names over verbs. The Don't forget to delete the folders that are now empty. I checked out this branch locally and they were still there. |
That's what I meant, yes: substantives, not sustantives. |
rturrado
left a comment
There was a problem hiding this comment.
@GuyPuts I think you have an issue in your environment. Your environment is forcing you to use an 80 column width, while we are using a 120 column width in OpenSquirrel (tox.ini). Please fix it.
That "fix conflicts" commit should be reverted.
…into CQT-151-Disentangle-internal-functionalities-from-compilation-passes
rturrado
left a comment
There was a problem hiding this comment.
Great! Good work! Thanks.
Moves the compilation passes functionalities to the passes folder. CQT-151.