[CQT-355] Add support for asm declarations#496
Merged
Conversation
Add initial pickup asm declaration in Parser.
Add tests. Add entry in Changelog.
juanboschero
previously requested changes
Apr 3, 2025
Move AsmDeclaration class to follow Statement class.
elenbaasc
dismissed
juanboschero’s stale review
Changes were made in accordance with the request.
Dismissed the review, so that someone else can approve the PR.
rares1609
reviewed
Apr 11, 2025
Contributor
rares1609
left a comment
rares1609
left a comment
There was a problem hiding this comment.
This issue looks good! The necessary additions have been made to circuit_builder.py and ir.py, and the AsmDeclaration class has the 2 attributes mentioned in the ticket. Furthermore, new tests have been added for this feature.
The only thing that seems to be missing is the test_rydberg_backend that should be added to test_integration.py (according to the jira ticket).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IR).Parser,CircuitBuilder,Writer.SingleQubitGatesMerger(to not merge across asm declarations).