[CQT-361] - 2-Proper order schedule#626
Merged
Conversation
Fix bit-variable-mapping with reverse circuit creation.
Add factor of -1 to wait time in qs-Exporter scheduler.
Add wait extended functionality in exporter. Add wait extended instruction tests.
elenbaasc
changed the title
elenbaasc
changed the title
Fix lint and type errors.
rares1609
previously approved these changes
Oct 16, 2025
Contributor
rares1609
left a comment
rares1609
left a comment
There was a problem hiding this comment.
In my opinion, the implementation itself is good. I was not able to find anything that might critically hinder the functionality, or otherwise improve it.
Most of my comments focus primarily on possible extra (stress) tests that check whether quantify_scheduler_exporter can handle edge cases such as empty circuits, negative wait times or overly complex circuits.
I will mark it as approved for the scenario in which you think the tests are redundant.
Resolve PR comments. Fix wait and barrier implementation.
elenbaasc
force-pushed
the
CQT-361-2-Proper-order-schedule
branch
from
bc03983 to
b86d66a
Compare
rares1609
approved these changes
Oct 21, 2025
Contributor
rares1609
left a comment
rares1609
left a comment
There was a problem hiding this comment.
This all looks good to me! 💯 I'd say its good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Schedulervisitor andOperationRecordTODO: Update Changelog after OpenSquirrel 0.7.0 release.
NOTE: This branch has additional base development branches that can be removed after merging to develop. These branches are: