Skip to content

206: Make discover_peer_contexts return NamedTuples to increase usability#207

Merged
Thom747 merged 3 commits intomainfrom
206-return-structured-datatype-from-discover_peer_contexts
Apr 16, 2026
Merged

206: Make discover_peer_contexts return NamedTuples to increase usability#207
Thom747 merged 3 commits intomainfrom
206-return-structured-datatype-from-discover_peer_contexts

Conversation

@Thom747
Copy link
Copy Markdown
Collaborator

@Thom747 Thom747 commented Apr 15, 2026

This implements #206.

I decided to go the NamedTuple route instead of using a dataclass, as the dataclass approach broke backwards-compatibility.

@Thom747 Thom747 requested a review from heevasti April 15, 2026 09:25
@Thom747 Thom747 self-assigned this Apr 15, 2026
@Thom747 Thom747 linked an issue Apr 15, 2026 that may be closed by this pull request
Comment thread qmi/core/context.py
Copy link
Copy Markdown
Collaborator

@heevasti heevasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merging.

@Thom747 Thom747 merged commit 27fe232 into main Apr 16, 2026
4 of 7 checks passed
@Thom747 Thom747 deleted the 206-return-structured-datatype-from-discover_peer_contexts branch April 16, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return structured datatype from discover_peer_contexts()

2 participants