This repository was archived by the owner on Dec 15, 2023. It is now read-only.
[DEM-1205] Issues with instrument adapters #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Issues
======
+ Solved 2
- Added 2
See the complete overview on Codacy |
|
|
||
| def __init__(self, address: str) -> None: | ||
| super().__init__(address) | ||
| def __init__(self, address: str, instrument_name: Optional[str] = None) -> None: |
Contributor
Author
There was a problem hiding this comment.
Do you know why this is invalid syntax? Should I remove the typehints?
| def __init__(self, address: str) -> None: | ||
| super().__init__(address) | ||
| class TimeStampInstrumentAdapter(CommonInstrumentAdapter): | ||
| def __init__(self, address: str, instrument_name: Optional[str] = None) -> None: |
qSaevar
force-pushed
the
task/DEM-1205/issues-with-instrument-adapters
branch
from
e9276d4 to
3814ae7
Compare
qSaevar
force-pushed
the
task/DEM-1205/issues-with-instrument-adapters
branch
from
3814ae7 to
3439b03
Compare
peendebak
approved these changes
Nov 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.