Skip to content
This repository was archived by the owner on Dec 15, 2023. It is now read-only.

[OP-NN] fix issue with peak_local_max #741

Merged
QFer merged 2 commits into from
May 14, 2020
Merged

[OP-NN] fix issue with peak_local_max #741

QFer merged 2 commits into from
May 14, 2020

Conversation

@QFer
Copy link
Contributor

@QFer QFer commented May 12, 2020

  • The unit tests that used peak_local_max result didn't take into account that the order of peak local max is not defined. The order was different in the new version.

@QFer QFer mentioned this pull request May 12, 2020
Closed
@QFer QFer requested a review from peendebak May 13, 2020 06:37
peendebak
peendebak reviewed May 13, 2020
View reviewed changes
Copy link
Contributor

@peendebak peendebak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QFer PR looks fine. Changelog is not completely related to this PR, but it is okay.

@QFer QFer merged commit 05c3905 into dev May 14, 2020
@QFer QFer deleted the fix/issue-740/peak_local_max branch May 14, 2020 07:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@peendebak peendebak peendebak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QFer @peendebak