Merged
Conversation
Closed
Agent-Logs-Url: https://github.com/Quafadas/vecxt/sessions/a9f62adf-d34a-4091-b317-d930c529c73b Co-authored-by: Quafadas <24899792+Quafadas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review vector implementations for missing BLAS delegation
Delegate Apr 4, 2026
*= scalar to blas.dscal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JVM
Array[Double]vector ops were inconsistently using BLAS.dot,norm,+=,-=, and/=all delegate to BLAS, but*=(d: Double)was using a manual SIMD loop instead ofdscal— the obvious Level 1 BLAS routine for in-place scalar multiplication.Change
*=(d: Double): Replace 12-line SIMD loop withblas.dscal(vec.length, d, vec, 1), matching the pattern already used by/=*(d: Double): benefits automatically since it delegates viavec.clone.tap(_ *= d)