Allow plain Int for row/column in Matrix slice syntax#88
Merged
Conversation
…t(0, ::)) Agent-Logs-Url: https://github.com/Quafadas/vecxt/sessions/cbe42965-c53c-46a9-ac77-aad94dae9c0f Co-authored-by: Quafadas <24899792+Quafadas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix slice syntax on Matrix to simplify usage
Allow plain Apr 13, 2026
Int for row/column in Matrix slice syntax
Copilot stopped work on behalf of
Quafadas due to an error
April 13, 2026 10:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mat(::, Array(0))worked but the more naturalmat(::, 0)did not, requiring users to unnecessarily wrap single-index selections inArray(...).Changes
MatrixInstance.scala: Two newapplyoverloads that accept a plainIntfor either dimension alongside aRangeExtender, delegating to the existingArray-based slice implementation:apply(rowRange: RangeExtender, col: Int)apply(row: Int, colRange: RangeExtender)No changes to
RangeExtenderitself — avoids ambiguity with the existing element-accessapply(row: Row, col: Col): A.Example