Skip to content

Conversation

@nahumtimerman
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 87.329% when pulling d1058b2 on winrm_https_customization into 664dd2e on develop.

@nahumtimerman nahumtimerman merged commit ea128cb into develop Apr 22, 2021
@nahumtimerman nahumtimerman deleted the winrm_https_customization branch April 22, 2021 11:20
result = self.session.run_cmd('@echo '+uid)
assert uid in result.std_out
stdout = result.std_out.decode('utf-8')
self.logger.info(stdout)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally, I dont like info dumps in log. some context is very helpful. but that code is working so your call i guess.

Copy link

@AdamSharon AdamSharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants