Skip to content

Feature/gil 625 fixing magic strings#631

Merged
alexazarh merged 5 commits intodevelopfrom
feature/gil_625_fixing_magic_strings
Apr 11, 2016
Merged

Feature/gil 625 fixing magic strings#631
alexazarh merged 5 commits intodevelopfrom
feature/gil_625_fixing_magic_strings

Conversation

@GilGald
Copy link
Copy Markdown
Contributor

@GilGald GilGald commented Apr 11, 2016

Description

Fixing the magic strings prefix and postfix.

Related Stories

List related PRs against other branches:
Bug #625

Breaking

NO


This change is Reviewable

@GilGald GilGald added the ready label Apr 11, 2016
@GilGald
Copy link
Copy Markdown
Contributor Author

GilGald commented Apr 11, 2016

Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions.


package/cloudshell/cp/vcenter/common/utilites/command_result.py, line 5 [r1] (raw file):
remove this 2 not used params


package/cloudshell/cp/vcenter/common/utilites/command_result.py, line 28 [r1] (raw file):
remove this line


package/cloudshell/cp/vcenter/common/utilites/command_result.py, line 34 [r1] (raw file):
remove redundant method


Comments from Reviewable

@GilGald
Copy link
Copy Markdown
Contributor Author

GilGald commented Apr 11, 2016

@alexazarh
Copy link
Copy Markdown
Contributor

Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


Comments from Reviewable

@alexazarh alexazarh merged commit f2eb1a8 into develop Apr 11, 2016
@alexazarh alexazarh removed the ready label Apr 11, 2016
@GilGald GilGald deleted the feature/gil_625_fixing_magic_strings branch April 11, 2016 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants